[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 2/4] xen/arm: Move make_hypervisor_node()
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>
- From: Koichiro Den <den@xxxxxxxxxxxxx>
- Date: Sat, 28 Jun 2025 23:06:02 +0900
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wvD+z2i2BZKsgAXBEBtWFa+x4cjns8adHkY3wJDThPw=; b=XyZrIxrYvdErOXhLSf6lCoIvQCbLsahs7wwP7Wp0WPvV8wfaMMtQcyXjuRohdpWLwnRFjRTiKhQ82vLzfC4X4FeCLMAJRTj+FNrWGL9cqUtiX6pmVZ2X4Ac11ZWNGAPDOckrHrCxjIxjkf0qLZz7L2scZ+HoOhFYe+A3e38s7SegU1Uiex+ZmTIJFAv267DRLW0H2oH30A+21pztIM0epg1gKiPezI43i3arpXWvIg5k3DDPWwtkam7eCf44lovVbVC1AkqaMc3Yklv/rqAD3fBgf3gx0V9jgHDqzzUYEqBXbe3pinil40jxYCykCdfvuBQKHJfwjpQXUjhl1+2C6g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CgfPfaI5wsQMCW7sOXmgoPIfnMBT4i/3GEeF4o1VmDRPClrI0zhGxvNlseVaCy44eO2CaAyyBtq1u59RzUKMkrei/0J5O04Oc0BzfOOOvkH/YkiuFaTGe3RypAh+I2AiTO49VoPiZ1Puvj9XxUKaT8EGjlqpETlErC2KfBZHrVx8qZC+JPx85avHqeNpZK+cTQmjZe/zKaMP21wOWyPcxlCWTm6BaC/HPpAKmDrDvz8G577r7sV5o5t4QvHnZEkzLCi1B7L96T1B/51sS1CeyO6UMtFRSqzUJOJGmb/Z+RVGpl69CrTUreQnwbImaP0/tK2Fmia+niyH1G4datXTfg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Sat, 28 Jun 2025 14:06:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jun 23, 2025 at 03:40:24PM +0200, Orzel, Michal wrote:
>
>
> On 21/06/2025 17:11, Koichiro Den wrote:
> > Even though make_hypervisor_node() does not rely on the /reserved-memory
> > instantiation when calling find_unused_regions() (the wrapper introduced
> > in the previous commit), the next but one commit will use it for PV time
> Unless for specific reasons, you should not rely on which commit gets
> committed
> first. Hypothetically there could be a different patch committed between this
> and the next one in your series. That's why it's not a good practice to
> mention
> order of commits in the commit message.
That makes sense. I'll rewrite the commit messages in v2.
Thank you for the review.
>
> > shared regions, in addition to the existing extended regions.
> >
> > Move it as a prerequisite for the commit after next.
> This one is particularly not useful.
>
> >
> > No functional changes intended.
> >
> > Signed-off-by: Koichiro Den <den@xxxxxxxxxxxxx>
>
> Other than that, LGTM.
>
> ~Michal
>
|
