[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Fix booting hwdom/1:1 domU with CONFIG_GRANT_TABLE=n
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 30 Jun 2025 07:37:47 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=peA+UmPyEvP+3FcgYX5ahP2mIrSZxO78lzjDHiF/nqQ=; b=d53D2DKISqU47z9KaEeAXhHHq+qCb2sDCg7fSFD15JWGIgE5AYJL6y74SNI/hXqFtWSO4vwT9SG/95n1KErpwYGAVSvP/D+hhs37fhJrMbLYnnh8XvEVAV68IORyPAK5Mldqwppx7sNLEpdIbIoMk/Z4tgE5vlPe2b9WLBJ+tEE+YCkN8YsYLO75NzPPxF+jbWguIQf8uJdTbfNZy4vCuM5jfyyy7hWiJH1puvA+C6ZHzlmb9cOwDOPkN8URSCNOwsGnyRJt9sUhgLCgh2lmol3X4Oy8hfb2ZFT30is01t+mNtiZKdcZGS6PknmlmMgINcNZZy0mD6vtuBLk0fo6ig==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=peA+UmPyEvP+3FcgYX5ahP2mIrSZxO78lzjDHiF/nqQ=; b=tScdID4/gsQPRt7dqUtx0aWnbs0aJNnmQYmkiVbqYFPpyVCMo+kEbbP/Gz+262XHjhUj/T+grbi8JpRh8YQgddsK4FkrJafXpfJxfcDZrZtKIMq0U1g1BWDPTAMOyD4P8HL4AWxDRyXLkbcZtN3Ecm43m5l8jg9V6wfQXhPKq9PCzgcGb2Zkiw7Yw5f2MnHicjEfNEMK8xKOrLuliUm1F03mvNMa65pYwwIdLeEdH2rYx+0KDoNrnOm97IHlR+8vQISXnjpf04pmQIxVKZcUhs7yo/vzG0HYqukf3g8jhMXOLTsizaoF65tGIS9hgTz7Eh11E3ZkQW6uA/5fp5i/Mw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=E4qk3pESZtJMTpyTPBKewly0Gx0vAEGG734+al38ozisq41Q1hvtX86YiozqA/hPQXFIFavJFtcUBSGHlC+0g0PBNh55+2chPKKBX5nFMxNfevxQVh2G4feOsbJt6xVKjbiSh9LTrfODcj9XvnpBmo2hXp4wJfnoiyeAD26nPPI8zJZbil3kJijiz1oXe7dCaN4tJQQEq9EYaBVNDJ3RMfMJssyPiHljoVmhwQy/H5EzQwByuoFnQvdoQEV0NQJ2dUJMF5ZDL2V+4/sZdHrrfI6omc3e51MKXJmv2XtRFxa7jebEh1qotSvcLK2R11y2E9RV7UJEPB3v2X9CoKRUbA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wBNLxhBlqsLcIO70KxOhP0EDi7XMerwNMFWNWM1NNLgnTrXMC4qkt/AVWC20owZl1KYrjEwWfqHMn8o0VQERhXvECSVMld/5BS5qSfG+pvsbaQ/7VbZb9MaytdMU0NcbXsIDR8Gbb0HlkyjClN3U2zZ2ihDotqMMxUKgUzAWsAmUfSHv9K+NQk+AnTX6PtGCmfHANqO6WHHqU2st/6SOrTVENfPcY5+9TYdTK82clgNf6OUsgHCEeQCqeWArW5A+HwFG+ISvjjR1Y5k/Ok9h6ehxYQMG894l1OoBWsjLT/2ZnyHgTKyMuMiNUmk0E9ZIrJlzpWgGCNLHqRXa8JGReg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 30 Jun 2025 07:38:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHb5bnKrH6hbt4bekO2oCqePGx44bQbWCiA
- Thread-topic: [PATCH] xen/arm: Fix booting hwdom/1:1 domU with CONFIG_GRANT_TABLE=n
Hi Michal,
> On 25 Jun 2025, at 11:12, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> At the moment, we unconditionally allocate space for grant table region
> membank and add it in the membanks array to find_unallocated_memory() to
> find unused memory. In case of CONFIG_GRANT_TABLE=n, the size of the
> region is empty and assertion in rangeset_remove_range() fails when
> booting hwdom or 1:1 domU without IOMMU. Example:
>
> (XEN) Assertion 's <= e' failed at common/rangeset.c:189
> ...
> (XEN) Xen call trace:
> (XEN) [<00000a0000218b5c>] rangeset_remove_range+0xbc/0x2d4 (PC)
> (XEN) [<00000a00002b8370>] find_unallocated_memory+0x140/0x208 (LR)
> (XEN) [<00000a00002cc28c>] make_hypervisor_node+0x310/0x7e0
> ...
>
> Same issue would occur when booting hwdom with LLC coloring enabled.
> Fix it by performing conditional allocation and configuration.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
The patch looks good to me, I’ve reproduced locally the issue and tested that
this patch
solves it, using FVP.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
