Re: [PATCH v3 15/68] accel: Remove unused MachineState argument of AccelClass::setup_post()

[Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>]

On 1/7/25 16:39, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
> ---
>   include/qemu/accel.h | 2 +-
>   accel/accel-system.c | 2 +-
>   accel/xen/xen-all.c  | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/qemu/accel.h b/include/qemu/accel.h
> index f327a71282c..a6a95ff0bcd 100644
> --- a/include/qemu/accel.h
> +++ b/include/qemu/accel.h
> @@ -45,7 +45,7 @@ typedef struct AccelClass {
>       void (*cpu_common_unrealize)(CPUState *cpu);
>   
>       /* system related hooks */
> -    void (*setup_post)(MachineState *ms, AccelState *accel);
> +    void (*setup_post)(AccelState *as);
>       bool (*has_memory)(AccelState *accel, AddressSpace *as,
>                          hwaddr start_addr, hwaddr size);
>   
> diff --git a/accel/accel-system.c b/accel/accel-system.c
> index 913b7155d77..af713cc9024 100644
> --- a/accel/accel-system.c
> +++ b/accel/accel-system.c
> @@ -58,7 +58,7 @@ void accel_setup_post(MachineState *ms)
>       AccelState *accel = ms->accelerator;
>       AccelClass *acc = ACCEL_GET_CLASS(accel);
>       if (acc->setup_post) {
> -        acc->setup_post(ms, accel);
> +        acc->setup_post(accel);
>       }
>   }
>   
> diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c
> index 1117f52bef0..ba752bbe5de 100644
> --- a/accel/xen/xen-all.c
> +++ b/accel/xen/xen-all.c
> @@ -63,7 +63,7 @@ static void xen_set_igd_gfx_passthru(Object *obj, bool value, 
> Error **errp)
>       xen_igd_gfx_pt_set(value, errp);
>   }
>   
> -static void xen_setup_post(MachineState *ms, AccelState *accel)
> +static void xen_setup_post(AccelState *as)
>   {
This method only accesses xen_domid/xen_domid_restrict, which are both
related to the 'accelerator', not the machine. Besides, xen_domid aims
to be in Xen AccelState and xen_domid_restrict a xen_domid_restrict
QOM property.

Regards,

Phil.