[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 03/10] x86: Replace arch-specific boot_domain with the common one
- To: Jan Beulich <jbeulich@xxxxxxxx>, Daniel Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Wed, 2 Jul 2025 17:04:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0VtO0xSKvYvtRmGAeHkwDLFMwyQWrku3ANzTOojKMLU=; b=dWaTPMw970GF8mo5W7x9DGOLwjy3JYceDYVo7O+dTNu9hG95xCXhB77yj2yxkcjSlR0MQjRNNmp7+22oDROKEP8pYizFKqFII2W3qXBzZ1GtuIXmfMCLenKFcnqHx/kr5frRC63/ww7XAebWYiUuQDUZ8M1vY3swL9YvT8ygtmq9JebViXOy8ROlFsEpCEmJ8ydouFJ3X9Yh8FOeo/UmcWCrXQxqZ7EMohEA1lPjFFjYK/Ol92BvNEjt32NrmmZIegxJfo9Ca4yhokP2AWBBKt4r8BmU3rPaCyi0Y7YOlOg/mBrZ3de2WrmUZAjzaokzuGkLlbVnkoZnzmT7aEYFhQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QEhpYbGzTNLGIl8uCLwInELJtJnPQv5CnoayMIostox2Nxis5I/AlnmjUPEIOhyQ1J2gfyDzTxwJhw3kMHM2eu9t096vLASiyWjhy7H/OyXgmzbZQLeUjCk/QnBgFMqL1OnmNznwfCDxFWa1oP2TxYvepFxE+mSgT1dmV7bjMrj17ZsmhCfQetJPAggoWok2UXXcdgch2G4nyqg/pjGsJM6kNSGAkF/L4/kuCtajWO8bLOvGGiFHygSvAqOhqp9MxRoKlWldYyim2DLElVxz/10s8BEzsC7QjP8zsF5SSgd5Bpr8gT8BktEHm4azBoyky9ngkhnhhmH8nXdM+uKIkQ==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 02 Jul 2025 15:04:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed Jul 2, 2025 at 3:15 PM CEST, Jan Beulich wrote:
> On 01.07.2025 12:56, Alejandro Vallejo wrote:
>> --- a/xen/arch/x86/include/asm/bootfdt.h
>> +++ b/xen/arch/x86/include/asm/bootfdt.h
>> @@ -3,6 +3,12 @@
>> #define X86_BOOTFDT_H
>>
>> #include <xen/types.h>
>> +#include <public/xen.h>
>> +
>> +struct arch_boot_domain
>> +{
>> + domid_t domid;
>> +};
>>
>> struct arch_boot_module
>> {
>>[...]
>> @@ -1048,11 +1050,11 @@ static struct domain *__init create_dom0(struct
>> boot_info *bi)
>> dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
>>
>> /* Create initial domain. Not d0 for pvshim. */
>> - bd->domid = get_initial_domain_id();
>> - d = domain_create(bd->domid, &dom0_cfg,
>> + bd->arch.domid = get_initial_domain_id();
>> + d = domain_create(bd->arch.domid, &dom0_cfg,
>> pv_shim ? 0 : CDF_privileged | CDF_hardware);
>> if ( IS_ERR(d) )
>> - panic("Error creating d%u: %ld\n", bd->domid, PTR_ERR(d));
>> + panic("Error creating d%u: %ld\n", bd->arch.domid, PTR_ERR(d));
>
> This being the only place where the (now) arch-specific field is used, why
> does it exist? A local variable would do? And if it's needed for
> (supposedly arch-agnostic) hyperlaunch, then it probably shouldn't be
> arch-specific? Daniel, Jason?
>
> Jan
It eventually becomes a holding spot for the domid property of each domain in
the DTB. It exists so we can describe every domain fully ahead of trying to
construct it.
Cheers,
Alejandro
|
