[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v4 57/65] accel: Always register AccelOpsClass::kick_vcpu_thread() handler
On 7/2/25 11:53 AM, Philippe Mathieu-Daudé wrote: In order to dispatch over AccelOpsClass::kick_vcpu_thread(), we need it always defined, not calling a hidden handler under the hood. Make AccelOpsClass::kick_vcpu_thread() mandatory. Register the default cpus_kick_thread() for each accelerator. Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> --- include/system/accel-ops.h | 1 + accel/kvm/kvm-accel-ops.c | 1 + accel/qtest/qtest.c | 1 + accel/xen/xen-all.c | 1 + system/cpus.c | 7 ++----- 5 files changed, 6 insertions(+), 5 deletions(-) Sounds good. Reviewed-by: Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxx>Unrelated, but I noticed that hvf_kick_vcpu_thread uses hv_vcpus_exit [1] on x86 and hv_vcpu_interrupt [2] on arm64. I'm not even sure what's the difference when reading the Apple doc, except that exit existed before interrupt. [1] https://developer.apple.com/documentation/hypervisor/hv_vcpus_exit(_:_:)[2] https://developer.apple.com/documentation/hypervisor/hv_vcpu_interrupt(_:_:) It might be worth moving x86 to use interrupt also, in a future series. Regards, Pierrick
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |