[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 02/10] xen: Refactor kernel_info to have a header like boot_domain
- To: Jan Beulich <jbeulich@xxxxxxxx>, Alejandro Vallejo <agarciav@xxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Thu, 3 Jul 2025 11:57:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TeFoMnOy8oVOAb2Mm/3vI66cwtfVRDa9P4HllKKHufQ=; b=nbuIqAflhf8mLXai2DDLIhyuyFVjPOHeVhgNw5mxczi5dp9ZYpmLpUtHoRL3HhrlCvhvMWvLcYKLHZVQwFww7zcmPFFuvvTx1f73vBsJSaSDXbKmiuY+MEA994vWiaX1/D0eVAZ2qxKC+32kprogeo8XYWuKsadO4DJvSL3n9usc0lP//Y5z5PjXD1801SFQKY7ql0QewzLVYFoxky3CEKJ3gB8iWPsstMcUUSBJjjt914rsER8n1ShImyGGVeJbHNPzqy+Kvl56MrW4L4HxWRMK2vGbBJ0TsFrpKMI9uApjP3LOGSWIVbUoQOkFCRKSyfbeqMBZ4PQpJnPR2qhc0g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZzX6QSTOKhirUhjzA8PLSScstujrzZkPhQvb74Q420qwL8MtTz/bOdmCzYRog68yIANtXaYZFM1YAGbAJjScL16rd6Nv46zGNnlqfta5AsjQRqwVynYMiS5RyTAXz08UXCKVyL/EYlajuVwWaS1pKviW0vLAw8x/nC/5bn4lfTsplkYiR6IPl6MaAUQrtz+S/6nTYFeS87o2GAtvVB87ql80uavIhBBKIpcJ5tpRAu7HEmiYPzYLq5butT7tu0cxxFQpLJ/UOBMXSywh/x6WS7pVcWJ7Up2wYzwP0Qq2tH80834BPn0au8ixaBwt+XM9jdArsp4hYn9D1mRVnbAIRQ==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 03 Jul 2025 09:57:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu Jul 3, 2025 at 8:01 AM CEST, Jan Beulich wrote:
> On 02.07.2025 18:04, Alejandro Vallejo wrote:
>> On Wed Jul 2, 2025 at 2:56 PM CEST, Jan Beulich wrote:
>>> On 01.07.2025 12:56, Alejandro Vallejo wrote:
>>>> --- a/xen/include/xen/fdt-kernel.h
>>>> +++ b/xen/include/xen/fdt-kernel.h
>>>> @@ -16,7 +16,7 @@
>>>> #endif
>>>>
>>>> struct kernel_info {
>>>> - struct domain *d;
>>>> + struct boot_domain hdr;
>>>>
>>>> void *fdt; /* flat device tree */
>>>> paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */
>>>> @@ -34,8 +34,7 @@ struct kernel_info {
>>>> paddr_t gnttab_size;
>>>>
>>>> /* boot blob load addresses */
>>>> - const struct boot_module *kernel, *initrd, *dtb;
>>>
>>> Where did this "const" go?
>>
>> x86 mutates the boot module to set the released flag, the headroom, etc.
>
> Might be nice to mention such an aspect in the description.
>
> Jan
Sure.
Cheers,
Alejandro
|
