[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v5 12/18] xen/cpufreq: get performance policy from governor set via xenpm
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Fri, 4 Jul 2025 07:51:36 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wyHSJfzn+ipkF5/AqtgIE+CIZfU6+kdYzRwITGjyb4Y=; b=rGUvfsq2NTUacWihfzfn+TB7zovSxzvhr8ExNxVkV1/iESwdSOBRdu8Vrzi1VV7hpa6Y4h6ywKYJiP998b9n42atzx49Gv8RrAOzik9yBIEb8kPzcSy/Y0msRGUK3CH0ba++zQfjNprwp2PJ8xh6uWBMzHUxW5444wxXXLdlfY3y53UyCYcDbmjuoQ9S8wi5ZLbE/elM2Cm1UMKYpc4rfJc57ylERqewnR4K3DntqLDVp+HzDLg5Ndu65dbknXjwhdGOFtMsFKg8nBeQr2LAfHucYK9Svd3kvzzkWi49Km5AHqF8EoAOMTF377nWy0lI87+rB+nw8bpzw3GCd0Sxgg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lP7R4nGmZO+vULSzOreC6ybkhDkg4glsvBl64YJ9rDsvVU2/X4kZHSr4eaK6fgPF0Bu/Q1hGawhHgJHZ1+StL59GABR6l+9VF9VZcOvxXHLxKE5EHfWe6bzOjn6eBD+sbC80Z+1VNm90r+QGGWHc8ot0D1HUNy2D2YOANng7R2DYvi4tO8+HGh0GfyNuEhnzrh1X91HJmKw/12tJMkbeTDfu9b7sZjriDw2EzzN2NinkraHgvOxsHC/ax3ldUXdvl1RtSvkGPL//8YCCxoclTxja4cU0Z6U6ZYF9IYMLKbTlPQdKszNpIEFHRV7SLm24GwtlWBZzEN6ltDReeVvrBQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 04 Jul 2025 07:51:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-07-04T07:51:16.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHbzuRGFA8e3uaaJU21iUm/xgVX/bQGF+yAgBuzwDA=
- Thread-topic: [PATCH v5 12/18] xen/cpufreq: get performance policy from governor set via xenpm
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Tuesday, June 17, 2025 12:22 AM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 12/18] xen/cpufreq: get performance policy from
> governor
> set via xenpm
>
> On 27.05.2025 10:48, Penny Zheng wrote:
> > --- a/xen/drivers/acpi/pmstat.c
> > +++ b/xen/drivers/acpi/pmstat.c
> > @@ -319,6 +319,14 @@ static int set_cpufreq_gov(struct xen_sysctl_pm_op
> *op)
> > if (new_policy.governor == NULL)
> > return -EINVAL;
> >
> > + new_policy.policy = cpufreq_policy_from_governor(new_policy.governor);
> > + if ( new_policy.policy == CPUFREQ_POLICY_UNKNOWN )
> > + {
> > + printk("Failed to get performance policy from %s, and users
> > + shall write epp values to deliver preference towards performance
> > + over efficiency",
>
> This message is excessively long and is lacking a newline (i.e. effectively
> two:
> one in the middle and one at the end; yet better would be to find less verbose
> wording). What's worse, how would a "user" go about "writing epp values"?
>
Maybe change it to
```
printk("Failed to get performance policy from %s, Try \"xenpm
set-cpufreq-cppc\"\n", ...);
```
> Jan
|
