Re: [PATCH 04/11] xen/pmstat: introduce CONFIG_PM_OP

[Jan Beulich <jbeulich@xxxxxxxx>]

On 07.07.2025 05:13, Penny Zheng wrote:
> We move the following functions into a new file drivers/acpi/pm-op.c, as
> they are all more fitting in performance controling and only called by
> do_pm_op():
>  - get_cpufreq_para()
>  - set_cpufreq_para()
>  - set_cpufreq_gov()
>  - set_cpufreq_cppc()
>  - cpufreq_driver_getavg()
>  - cpufreq_update_turbo()
>  - cpufreq_get_turbo_status()
> We introduce a new Kconfig CONFIG_PM_OP to wrap the new file.
> 
> Also, although the following helpers are only called by do_pm_op(), they have
> dependency on local variable, we wrap them with CONFIG_PM_OP in place:
>  - write_userspace_scaling_setspeed()
>  - write_ondemand_sampling_rate()
>  - write_ondemand_up_threshold()
>  - get_cpufreq_ondemand_para()
>  - cpufreq_driver.update()
>  - get_hwp_para()
> Various style corrections shall be applied at the same time while moving these
> functions, including:
>  - add extra space before and after bracket of if() and switch()
>  - fix indentation
>  - drop all the unnecessary inner figure braces
> 
> We shall also provide "# CONFIG_PM_OP is not set" in preset configs for
> PV shim on x86.
> 
> Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> v2 -> v3
> - new commit
> ---
> v3 -> v4:
> - rename the file to pm-op.c
> - drop all the unnecessary inner figure braces
> - be consistent with the comment on the #endif
> ---
> v4 -> v5:
> - add blank line before endmenu
> ---
> v5 -> v6:
> - rebase changes from "xen/cpufreq: normalize hwp driver check with 
> hwp_active()"
> and "xen/cpufreq: move "init" flag into common structure"
> - add "# CONFIG_PM_OP is not set" in preset configs for PV shim on x86

Correct here (and in the next patch), but both additions will want undoing then
in the last patch, as their dependency on SYSCTL thus covers what we want.

Jan