[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] xen/arm: Move make_resv_memory_node()
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- From: Koichiro Den <den@xxxxxxxxxxxxx>
- Date: Wed, 9 Jul 2025 16:58:32 +0900
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aardLZ7aQxGLfLPNkNXAqLZh06MA7rO5nsuQdf/hrdY=; b=Erh6lAct0XmUB6ICnFnmlte8IBGBPI27RNM8vzHCnfmwqe9TPyJVjDtJ5IXXQHzjtYvSqoLeMfgJIH+vVMsDg2Kk1HCIGj/WX7ezu5yxsZpTzJUdq5SxYXWwr9bC+BWQCZ/8t6ge1A7k+eBdY512xcSZ/u/KEieviijgfxD7irYuBypzE6BfXehDbFFKUXgUhcn9T2RRIOcLFDPE26W2RUKeuCpr4n3lSPcbnAodOeLQmxfKioOrcKw5e56Vch7uEQUvUdAtZrVSeRVsQR7HbAZAq/oQUqo6ZDbYZR96tgJQuDBnKnhmrWUnyoY7LfFq6QwGpN4s9OqM1tHq6cuEjQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xhBB7Fv5/fr5NDd4rQgvUf4SwzSwZvk/YYb4bxzN8u5vmG5EBI6kJFdNhLrQQ3TkGACxcZMykJ+dYYR0Wj3npQb6EsKCc1Dy8Wj8fb+PpWFuHwTJ3kcKA4Qxi1ofNChVW3uRwxOQ3ignBFPRjnDCIAz8RMT4JeHZEptUVQ1nsMbkfHhHewOb+gAjM55LYpZFNBWaks8fbehrbdi/B4pStPSkv1kL9/mHnVmTLfqgMoQzmzdJK3vwSuRnvjlVQgp2K+u0hYwRmkWP8qbAXI8MuUgxJvFcD5w0TGUPz73RMB5KNLQ/e5mxnznL5KHHot2DQGQa5Bd/ZHfAbqy0VcNrsA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 09 Jul 2025 07:59:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jul 08, 2025 at 04:12:50PM -0400, Stewart Hildebrand wrote:
> On 7/5/25 10:27, Koichiro Den wrote:
> > The /reserved-memory node is inherently not specific to static-shmem.
> > Move it to a more generic domain build context. While at it, add an
> > empty kernel_info_get_shm_mem_const() for the CONFIG_STATIC_SHM=n case,
> > as it can now be invoked in such case.
> >
> > No functional change.
> >
> > Signed-off-by: Koichiro Den <den@xxxxxxxxxxxxx>
> > ---
> > xen/arch/arm/domain_build.c | 40 +++++++++++++++++++++++++++
> > xen/common/device-tree/static-shmem.c | 40 ---------------------------
> > xen/include/xen/fdt-domain-build.h | 2 ++
> > xen/include/xen/static-shmem.h | 15 ++++------
> > 4 files changed, 48 insertions(+), 49 deletions(-)
>
> make_resv_memory_node() was recently moved from arch/arm to common in:
>
> 72c5fa220804 ("device-tree: Move Arm's static-shmem feature to common")
>
> Is there any rationale for moving it back?
I overlooked that commit. So to preserve its intent, and make it usable
outside of the static-shmem purpose, which is my original intention, I
think I should place it in xen/common/device-tree/dom0less-build.c. What do
you think?
Thanks,
-Koichiro
|
