[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] tools/xentop: Add physical CPU statistics support
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jahan Murudi <jahan.murudi.zg@xxxxxxxxxxx>
- Date: Wed, 9 Jul 2025 08:37:07 +0000
- Accept-language: en-IN, kn-IN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l6ok2KhIP03lcaHa92B8AbwxuUrNq2XGT5CTzBo/7VU=; b=iYdJKHnG9PmyZmaEb5NS4IfjTgR9U0TG+64pzH5l7bAq/dGXgrjKj7d2kjb9/NQoWznksXIIW1DaX2NNe6I3+VmAsX6RLwaVz0wJqhTkyjuLLyjudQwUoiLteJ1aNnB4YzQaGsbfUAK/ws9UHtQvCzxLpChVe63eZIvIthVkuiARkK/vDGZ/0nFdF/5WM5ebGZ/KVA0efii48Bc87iBrKZ9WIDIckXDMxI5X4WlkLXcxA4m1d7YpwewI/RWNZct5iLqg/Mrj9sJRZjH+fKzEoqwi4hwU+wiUSwbtdPY7BMCEx2y5qzJJai8WRcCiAr1CjBEIIQkS/mfBRY42uC8FvQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ReEeism2UAew+pNUaY1p3Rrd48CKXC+fUuSCNirwGSBpcwZk0LKKAoUxewv7gUJgEedpN7ku7Lrdjqcho4iICYqH79aD2jgbWnyVXEVao/ND8mzk80ZRw31v/IVPGljXjZcnu3kJfSI50aLYJbQcaHWAFkZuLtxuaJ7xs9GY/yHmOC6B/jVERX86dc48dDew0Fh5WAKNbcrgj4m8lxjCl3Tn8I5IFAfltubJ4qJNZs4KO6LcYgXdz+SOsPsYqBmWKZ+f2WspuUFWVyaYCVLkla+vOD7LHw7Q2ZMMqbyJ5120Hy6k+4xSN/Igs2yh0/o7RWZzGKYUd6lbDKEVD1saAw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com;
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 09 Jul 2025 08:37:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHb7/4FGehggkKGsUyTQlD7iNI2ErQoPOkAgAE6+EA=
- Thread-topic: [PATCH] tools/xentop: Add physical CPU statistics support
Hi Jan,
Thank you for your review.
> On 08/07/ 2025 19:15, Jan Beulich wrote:
>> +pcpu.o: pcpu.c pcpu.h
>> + $(CC) $(CFLAGS) -c $< -o $@
>> +
>> +%.o: %.c
>> + $(CC) $(CFLAGS) -c $< -o $@
> As you mean to re-submit, you may also want to tidy (back) the above. You
> don't say why you need to spell out both the explicit and the pattern rule
> here. And I don't think this is actually necessary. All you ought to need is
> indeed the addition of the extra prereq object file.
You're right - these explicit rules are redundant. In v2 of the RFC patch, I've
removed both the explicit pcpu.o rule and the pattern rule.
https://patchwork.kernel.org/project/xen-devel/patch/20250709082810.3052544-1-jahan.murudi.zg@xxxxxxxxxxx/
Regards,
Jahan Murudi
|
