Re: [XEN PATCH v2] automation/eclair: Make report browsing URL configurable.

[Anthony PERARD <anthony@xxxxxxxxxxxxxx>]

On Mon, Jul 07, 2025 at 05:28:26PM +0200, Nicola Vetrini wrote:
> diff --git a/automation/gitlab-ci/analyze.yaml 
> b/automation/gitlab-ci/analyze.yaml
> index 5b00b9f25ca6..9cec0f65a439 100644
> --- a/automation/gitlab-ci/analyze.yaml
> +++ b/automation/gitlab-ci/analyze.yaml
> @@ -8,7 +8,10 @@
>      ENABLE_ECLAIR_BOT: "n"
>      AUTO_PR_BRANCH: "staging"
>      AUTO_PR_REPOSITORY: "xen-project/xen"
> +    ECLAIR_ANALYSIS_RESULTS: "https://eclair-analysis-logs.xenproject.org";
>    script:
> +    - export ECLAIR_ECDF_DIR
> +    - export ECLAIR_REPORT_HOST

I don't think these two "export" do anything useful, unless for some
reason there's a "before_script" in yamls that set those two variables
without exporting them. Otherwise, those two are expected to be CI
variables, so they should already be in the environment, so no need to
export them again.

>      - ./automation/scripts/eclair 2>&1 | tee "${LOGFILE}"
>    artifacts:
>      when: always

Beside this one comment, the patch looks good to me:
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD