[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] xen/x86: address violations of Rule 11.3



On Wed, 9 Jul 2025, Jan Beulich wrote:
> > What fine grained deviation do you have in mind?
> 
> Ones for almost(?) everything that is having actual code changes right now
> in this series.

We could easily deviate alternative.c based on the file name alone. But
for the rest:

emulate.c: casts from unsigned char* (byte aligned) to uint64_t* (8 bytes
aligned)

vlapic.h: casts from uint8_t* (byte aligned) to uint32_t* (4 bytes aligned)

setup.c: games with symbols

iommu_init.c: cast from uint32_t* (4 bytes aligned) to uint64_t* (8 bytes
aligned)

How would you deviate these in general terms? Or are you suggesting to
use SAF tags for each of them?

I suggest we consider taking the patch as is, or globally deviating this
rule for x86 (or keep the rule but not enabling it in ECLAIR for x86).



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.