[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 1/3] iommu: address violation of MISRA C Rule 5.5
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- Date: Thu, 10 Jul 2025 09:44:38 +0000
- Accept-language: en-US, uk-UA, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VLvzecUAdmF3ynvpfPirnoTjS81nBJorZ0VB1bT9+k0=; b=NtwjMJ07L2NR6t5vYGiU4h68TpeAs6yB+6kKKaUVHSiJMx9LCBN+TPsLIGar3HLveXmCi95t2iOiSaJJcc0MLjssaemqIXeg1oyLeyfG0X89ntZGv01GGxxueK4wm0LnKeEtM18Yv4QZYd94RqqDT6UHibSLhFEyVqjiQ4B7o694lRoVJeXYrPVF3O6wFJbVKJBU70q72rgGAXzL4UXoj+VleuaeMzdnegl+yUW7dtZLn/23mKp0PVBcJ5I0G7eqGjLudAqUocxkGw7w7Ui0lXK4mH7zqoOHc43F0SQDQCP8kK6vi2ePqDZ/CGyY23N8CY4ofmVgjRjbrrWk3EOo9w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZcTHqQehyUBYMOv7ylUYeG3GiEpWvaKwbIIRtaTiRqYwOA1/eXt8Hh8+SzDL4M3biDvjejwi2kescl4c5DfKTIazm+reeeY6QlTFow4GjTNGv8lSN0R5neLzxIhVn2tz2GUFJveLXh+Ccqk6JjsEMnmGU3M3sQuGhSRteMz8yzZnG/T4juvvn7GoQKIfBkB3VIFZnVAUD5bYZMVgwPDMVe7ROUc7tpx2U3eiGQJ3e3S4cE+5nHdwJVdQ8hmSPGwbVUWV1t8yOhWdTk4bFOCfrzn6O9C+rCor1/k3VfqCyHliG8l+UCULmD6SDF3I3teUFozKbItzZYqjvhd3IYSReQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 10 Jul 2025 09:44:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHb8RnHknh9PmNpckO7ne8U6W29yLQrBRIAgAAXOYA=
- Thread-topic: [XEN PATCH v2 1/3] iommu: address violation of MISRA C Rule 5.5
Yes, sure. I'll update commit message.
Thanks!
On 7/10/25 11:21, Jan Beulich wrote:
> On 09.07.2025 23:38, Dmytro Prokopchuk1 wrote:
>> Address a violation of MISRA C:2012 Rule 5.5:
>> "Identifiers shall be distinct from macro names".
>>
>> Reports for service MC3A2.R5.5:
>> xen/drivers/passthrough/iommu.c: non-compliant macro 'iommu_quarantine'
>> xen/include/xen/iommu.h: non-compliant variable 'iommu_quarantine'
>>
>> There is a clash between function name and macro.
>> Add an 'extern' declaration for 'iommu_quarantine'
>> under the same preprocessor condition (#ifdef CONFIG_HAS_PCI).
>
> Perhaps s/Add an/Put the/ or some such? You don't add any declaration,
> after all.
>
>> This ensures that the declaration is consistent
>> and only exposed when CONFIG_HAS_PCI is defined.
>>
>> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
>
> With some suitable adjustment (happy to make while committing as long as
> you agree):
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Jan
|
