[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2] misra: address violation of MISRA C Rule 10.1
- To: jbeulich@xxxxxxxx
- From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Date: Fri, 11 Jul 2025 15:00:25 -0700 (PDT)
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, dmytro_prokopchuk1@xxxxxxxx
- Delivery-date: Fri, 11 Jul 2025 22:00:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, 11 Jul 2025, Dmytro Prokopchuk1 wrote:
> Hi All.
>
> In this 2nd version I made changes according to the
> https://patchew.org/Xen/d92cf08a64d8197a1d1a45f901e59183105d3da5.1752183472.git.dmytro._5Fprokopchuk1@xxxxxxxx/
>
> There are 0 violations on the ARM64 as you can see in the report:
> https://saas.eclairit.com:3787/fs/var/local/eclair/xen-project.ecdf/xen-project/people/dimaprkp4k/xen/ECLAIR_normal/fix_10.1_rule/ARM64/10650097988/PROJECT.ecd;/by_service.html#service&kind
>
> Jan mentioned:
> "As to the kind of change here - didn't we deviate applying unary minus
> to unsigned types?"
>
> Here is that deviation:
> https://patchew.org/Xen/7c7b7a09e9d5ac1cc6f93fecacd8065fb6f25324.1745427770.git.victorm.lira@xxxxxxx/
> As you can see from report
> https://saas.eclairit.com:3787/fs/var/local/eclair/xen-project.ecdf/xen-project/people/dimaprkp4k/xen/ECLAIR_normal/deviate_10.1_rule/ARM64/10648749555/PROJECT.ecd;/by_service.html#service&kind
> there are still 2 violations.
> And they can be easily fixed.
>
> So, Jan and Stefano,
> which approach should we select?
I think we should go with the global deviation.
Jan, if you look at the code changes on this series, many of them are
undesirable. And the series is only addressing the ARM violations: it is
only going to get worse for x86.
I think we should commit:
https://patchew.org/Xen/7c7b7a09e9d5ac1cc6f93fecacd8065fb6f25324.1745427770.git.victorm.lira@xxxxxxx/
Jan, are you OK with it?
|
