[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] xen/arm: Skip loops in init_pdx() when no PDX compression is used



Hi Michal,

On 04/07/2025 08:54, Michal Orzel wrote:
When CONFIG_PDX_COMPRESSION=n, pdx_init_mask(), pdx_region_mask() and
pfn_pdx_hole_setup() are just stubs doing nothing. It does not make
sense to keep the two loops iterating over all the memory banks.

I saw this was already committed. But I have a question. Wouldn't the compiler be able to optimize and remove the loops? Asking because we are trying to limit the number of #ifdef in the code hence why we have stubs.

Cheers,

--
Julien Grall




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.