[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/6] arm/mpu: Implement early_fdt_map support in MPU systems
- To: Hari Limaye <Hari.Limaye@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 14 Jul 2025 09:26:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=na+S10sKHAWCdrEawP8P3b7ZKtus1Texgp8Nkz2kr6Y=; b=tzjSqNghoAyuG7dnif1mnT0qj6tSjaHMJe6BBkl9dIOQWI2ALfR00HEsCkaXar5wCzvKPQNasUYLmBfD6pUSNpMSXp5yIkBQO7vixWmh5rAhrh0u2DxxN0FUzg06vEMhdxs9lJVE2CRS6zZILvy6o57z5NDVlUQZzIacrzg7QZK74xlY+J04dWiiBC6IZSSgAkFP4IQJ8TLqN8TbpkY9Kj2Gi4Oz2X+CbFi2ghhu0PG2tUu0ubLDvSxVakTVT8FuEfYvx51/vvP2SaUlOOWeI3Z6qvwpdnqh4cgv/bVZpjP3pQ6Mo5qOggTqBMCpfq7FawELs7y3Flu0yBjjyyCZRA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mr9PjbD8q0QDOoZSVuI+ukp73u4ldB0q16h0lhH92IGHyyQeYTDl4Bv8YyyKDG9js7Al7E7+QhSvlhbA+nQfT3WhU4JwoDtOxanZ/SG33tB3Flmag/Unwr03k+Wk1a5HcBxemqq2TjOW+b4BHZyEoRYcZTTStMxGBpxjll7l4XSN1SKvHjNlSJPR9RZ5rHLI1Ut0ucEJzoqsR8uoZbUPbiUH2fqmPHd8lenBi37zCdQKCoUmM1Aj5Ew+J3DCGY2P294fOTumRwG67aS3svZF/NdGc5FT5TG3+lHXzsaXxDQy8dlBIqsvOlvuwwZDhS/wK/sfWUyx6ysC1vkkQBTjIw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Luca Fancellu <Luca.Fancellu@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- Delivery-date: Mon, 14 Jul 2025 07:26:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/07/2025 08:05, Hari Limaye wrote:
> Hi Michal,
>
>
>
> Thank you for reviewing the patch. To answer the following question:
>
>> > + /* DTB starting at this address has already been mapped. */
>
>> When can this happen?
>
>
>
> In xen/arch/arm/setup.c `start_xen` early_fdt_map(fdt_paddr) is called twice,
>
> before and after `setup_page_tables` - which is a no-op on an MPU system. This
>
> seemed like the neatest way to handle this - but maybe you'd prefer further
>
> clarification in the comment here?
Yes, I would like this comment to be improved a bit.
~Michal
|
