Re: [PATCH v2 08/17] public/io: xs_wire: Include event channel in interface page

[Juergen Gross <jgross@xxxxxxxx>]

On 16.07.25 23:14, Jason Andryuk wrote:
> Include the event channel in struct xenstore_domain_interface.  This way
> the toolstack or xen can communicate the event channel to xenstored in
> memory xenstored already needs to access.
>
> xenstored maps the grant with the well known GNTTAB_RESERVED_XENSTORE
> index, so no further information is needed.
>
> Suggested-by: Juergen Gross <jgross@xxxxxxxx>
> Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
> ---
>   xen/include/public/io/xs_wire.h | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/xen/include/public/io/xs_wire.h b/xen/include/public/io/xs_wire.h
> index e92a87a07b..f2c0afd107 100644
> --- a/xen/include/public/io/xs_wire.h
> +++ b/xen/include/public/io/xs_wire.h
> @@ -110,6 +110,7 @@ struct xenstore_domain_interface {
>       uint32_t server_features; /* Bitmap of features supported by the server */
>       uint32_t connection;
>       uint32_t error;
> +    uint32_t evtchn_port;
>   };
>   
>   /* Violating this is very bad.  See docs/misc/xenstore.txt. */
> @@ -134,6 +135,12 @@ struct xenstore_domain_interface {
>   #define XENSTORE_ERROR_RINGIDX 2 /* Invalid ring index */
>   #define XENSTORE_ERROR_PROTO   3 /* Protocol violation (payload too long) */
>   
> +/*
> + * The evtchn_port field is the domU's event channel for xenstored to signal.
Nit:

s/domU/domain/

This might be the interface of dom0 to a xenstore-stubdom, so "domU" is not
fully appropriate.

With that fixed:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature