[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 8/9] mm: introduce and use vm_normal_page_pud()
- To: David Hildenbrand <david@xxxxxxxxxx>
- From: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
- Date: Fri, 18 Jul 2025 11:47:27 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bwXcW/thTiG3JX7MT1dV9jjpzO932RIl/NjAnfgWrM0=; b=anoI7pkUoE+2OG/3GUpgl1fmuhPy+usXQmUUAbpF9liAAa+r9wXAhukSfRyBEN8bB73MioJjGyfhNtIvWZQuATeaRLm9m+neOS1KbO9hBYkCpWPpIL/qKaw+MpuDzww4xlFxi/Me3mvUPRsh68fOR3UIBwrl3lhp4vn72/m2sMGQWF/jZ4yNMWXKtE0VDrK/PhEntJy9HqPYY/noi6vJeirDQ5Oyyv/laCqbwAIkXSIqEolxeVzpUm+DgN2yJ1ZQDVzcjFL6sv3pjOLa846LE8Vd7YXXDwZi7MK2547xlO1VjwL3BuFQCyyJw0gb1M/1A3GtgEw5HZ8BqUKAWDq9yg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u2mJbB+POgajZDttIEPQ4XhdnF/z5UNhJqQULdIHg5UaifTD9ApDRhYCCBxiJDQ253ysfwHItvyTEqsTjfvew4iu7VSgEPRxHmUZTG+7iLohg3Lo00iY7jc/8WX8Sqom1XFMp3iSh70DmWL/foE9ENttYCQU4tqr7pPLtUm2CtizsJyD/ic9KbvbfwwIWOIx5hPRZsVVKIGVvcMrbiR3KjIJr7ieJnDMyua1w+SNOGUBrSor9sj4AzWKgPMa6HFkOikTf2MQbWEGdw4B4yHOzrCaMSR+R57nQS+8LRsvqO9eHxgsgFryfdECLu/ikJ/X9lA2BxXfJRCJBz4m+Yjq0A==
- Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>, Suren Baghdasaryan <surenb@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, Zi Yan <ziy@xxxxxxxxxx>, Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>, Nico Pache <npache@xxxxxxxxxx>, Ryan Roberts <ryan.roberts@xxxxxxx>, Dev Jain <dev.jain@xxxxxxx>, Barry Song <baohua@xxxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Pedro Falcato <pfalcato@xxxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, Oscar Salvador <osalvador@xxxxxxx>, Lance Yang <lance.yang@xxxxxxxxx>
- Delivery-date: Fri, 18 Jul 2025 10:48:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jul 17, 2025 at 10:14:33PM +0200, David Hildenbrand wrote:
> On 17.07.25 22:03, Lorenzo Stoakes wrote:
> > On Thu, Jul 17, 2025 at 01:52:11PM +0200, David Hildenbrand wrote:
> > > Let's introduce vm_normal_page_pud(), which ends up being fairly simple
> > > because of our new common helpers and there not being a PUD-sized zero
> > > folio.
> > >
> > > Use vm_normal_page_pud() in folio_walk_start() to resolve a TODO,
> > > structuring the code like the other (pmd/pte) cases. Defer
> > > introducing vm_normal_folio_pud() until really used.
> >
> > I mean fine :P but does anybody really use this?
>
> This is a unified PFN walker (!hugetlb + hugetlb), so you can easily run
> into hugetlb PUDs, DAX PUDs and huge pfnmap (vfio) PUDs :)
Ahhh ok. I hate hugetlb so very very much.
Oscar is doing the Lord's work improving things but the trauma is still
there... :P
Also yeah DAX ahem.
I'm not familiar with huge pfnmap PUDs, could you give me a hint on this? :>)
>
> --
> Cheers,
>
> David / dhildenb
>
|
