[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH 2/2] xen/arm: irq: drop unreachable pirq callbacks
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
- Date: Fri, 18 Jul 2025 14:47:26 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9P/DnrReDH7XcDbVthez/Ru4DXxJDgHSgHbDKszeTNk=; b=XnCgURUT7zNB7i5x5VZ26ijNUHFXkpbBwBZDpxdikWJw+Qy/VelaTKHrcTBYY8nxLFgwl6JFk4Kciht0GyEeJb2Q+3iW5LLRcFbteBOzU1mE8M9ke6qpAd/vyDawwA501SQOvAelOIIHuumfrc0PjVmE3P3OUc9YLPunR22tu/cV51kCWvB1Dq16KwGddH59HaKnqw1OcIND7Ei/Y93c8N6OF+ZNOnN5uQMjAyHcUoDca61QWALhVTKVZ4DxOaKGmLb7A1vP9yPWR9IJFcuRzGoxm3kI1U/ENA6do/GCmu/oGhOR/zmtNjgOmCy3gvB0JN/3AE5c5cAvMZgc41pihw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ok4j4xSpAksR2giFP7m+J+QdJ5nlnvfzclBFOFow30pljksJNE0jZcK+uJhC58yVLUY6YBNswfe4vb5WGrRimhnf7iRBSXAdqvr2g+oq/NQps1UoY7Nd9tlmj0O4IH2CroZT0tdkuox2NooE9gi7iUjsqwFKS9spe5wOGXSmy8kfFL0Nt1kQjUF+0KxwYDxyBPvvvzxZCyesy9toPseGSCksWVb48Axss9lnB2OBC54/ovXD08Tz76evS7DZRuE9kzDKvIBXGoFJ185Uj40Tbxi/qHULrfWmbjFinLzy2CLyKinYNBLOs7mSdFD0S74MtN6a5Z/2fZlqBDDjncZYgg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Ayan Kumar Halder <ayankuma@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 18 Jul 2025 11:47:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.07.25 13:22, Jan Beulich wrote:
On 18.07.2025 12:11, Grygorii Strashko wrote:
From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
Hence all common PIRQ code is under CONFIG_HAS_PIRQ idefs corresponding Arm
arch callbacks become unreachable, so drop them.
Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
---
xen/arch/arm/irq.c | 29 -----------------------------
1 file changed, 29 deletions(-)
Can this really be a separate change? That is, aren't we going to have transient
Misra violations (for Arm only) between the two changes?
The violation exist even before this series, and applies to arm/ppc/riscv
actually
alloc_pirq_struct - unreachable
pirq_guest_bind - unreachable
pirq_guest_unbind - unreachable
pirq_set_affinity - "reachable" at least from compiler point of view.
Would you like to have cumulative, cross-arch change to drop above arch
callbacks and
squash it in previous patch?
--- a/xen/arch/arm/irq.c
+++ b/xen/arch/arm/irq.c
@@ -595,35 +595,6 @@ unlock:
return ret;
}
-/*
- * pirq event channels. We don't use these on ARM, instead we use the
- * features of the GIC to inject virtualised normal interrupts.
- */
-struct pirq *alloc_pirq_struct(struct domain *d)
-{
- return NULL;
-}
-
-/*
- * These are all unreachable given an alloc_pirq_struct
- * which returns NULL, all callers try to lookup struct pirq first
- * which will fail.
- */
-int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share)
-{
- BUG();
-}
-
-void pirq_guest_unbind(struct domain *d, struct pirq *pirq)
-{
- BUG();
-}
-
-void pirq_set_affinity(struct domain *d, int pirq, const cpumask_t *mask)
-{
- BUG();
-}
-
static bool irq_validate_new_type(unsigned int curr, unsigned int new)
{
return (curr == IRQ_TYPE_INVALID || curr == new );
--
Best regards,
-grygorii
|
