[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ImageBuilder] Make DEVICE_TREE optional parameter
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Tue, 12 Aug 2025 18:34:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EE+WDBFdkOTTKLb5YGL7lXIYeIyHTEfZAeWs0p4Tdtw=; b=miv7i0HhSZiwq/tDg4e8X83O9TN5BCl6yweSdIF5oYyb/awE/gHT1Bd7ZqjCZ3350TppRz1La6vCUcZKdos7oRRfpgcGg1kXRVzoK/6vAG8Dblqe7G66GvhObkqwFUa8nDSO7Z/0oN5bYBwcwRPBpiY21SC9VzYUZx30VuY+uUjzdhvYJY0tnHnCHhO73+LpfnKKs6F5NGAZz04zUWps9uabQEToovibezbI9dX09hR8OIXBXN5EAggo0vtcKJP0DMotn4Zgx/NNtoOe0/Su2VOcuhWa2TjsGK/n07lYPDTUlTxojMhFclP8jjksIlyoJiDgyV6Hm+5Ufu/aZCywtA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hMcl+n0nbWd7yJJqA/EPlN2h3EJRWhQ5CBKwAya0PvUSdvOAfDf0RZ8bKovcjBQ9l6/Cg1QyOc6vZgyQisGW+G0AkMQfxNTceXK5aou592r17uA5VM4AyGluAaz4xG6Xc9tXdvDkH6HXUqCUtQRXuQLzR7eAiWpg+k+VuYK61MS/4oY5roJp0tGXi5GK5EHhVIpZKjb7q81ANG4nOnJK9zEH4ATjomuoeboADpPVCSzNqJzEKwI1jGNfEOOQc22LFHFbGdfMA7kvkosyhAnoIHOulxzx1Xs3/k2K5d9CQcMau0S7QjWE2vwUkE+o2CAmaoCLovJwI21pq4fScaZLWQ==
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <michal.orzel@xxxxxxx>, <andrei.cherechesu@xxxxxxx>, <dmukhin@xxxxxxxx>
- Delivery-date: Tue, 12 Aug 2025 17:35:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Stefano,
On 12/08/2025 00:13, Stefano Stabellini wrote:
On Thu, 7 Aug 2025, Ayan Kumar Halder wrote:
There are systems where device tree binary is passed by the U-Boot as
$fdtcontroladdr. In such cases, no external device tree binary is provided
during uboot script generation.
This is an enhancement on top of the following commit:-
uboot-script-gen: Dynamically compute addr and size when loading bina…
When DEVICE_TREE is not present, $CALC is set as the addresses and sizes should
be computed dynamically from U-Boot.
I would prefer if we did not automatically enable $CALC. If it doesn't
work without $CALC enabled, we could add a check for it and print an
error and exit. I would prefer that then enabling $CALC silently.
Ack
Also I don't think we should use the check ${DEVICE_TREE+x}. I'd prefer
to stick with the existing checks based on test ${DEVICE_TREE}.
Ack
The rest looks OK.
It might be possible to simplify this patch down to this (untested).
The last chunk of the diff is actually an unrelated fix, it looks like
we didn't test BOOT_CMD="none" when the -s option was introduced.
What do you think?
Slightly changed the chunk. With that it works well.
I have sent "[ImageBuilder v2] Make DEVICE_TREE optional parameter" for
review.
- Ayan
|
