[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v6 7/8] tools/xenstored: Remove stubdom special casing


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Fri, 15 Aug 2025 17:35:55 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ew1kABlxkh9uuRA1y1N6NUP22h+9pypvGUCR2HNQr2Q=; b=BwScjzo6So78v0yW06DXXh4ulV+V58a0t3JHUMXg/7SrYbsTMSAOFDx6RKo2aH2SxHPD/0zE7GexW0Sj1oDgvWQL8b7qDx3LhY2VF5Vwgx5l+YaAU6Mw8ZLs6jAeTwJ04+d6u4xFNjZ/S6kW8Eivjmtfi4o6psFPeTUPHby/xcEoqYAH0dqzBytX/QIZMgm7SL0D7xDZ80xr5y9Q2hVYJXm1DP2Ct/VS5FHfbZLgehN56d6rHxBIJ3rieS7hTpOj7Q11pAg3RbN+6EJgwHMYN0CrSJR5mt4Gmx8+MC3oM1To0qZks6dBgiF7du7BNP0R/nn08HArCsqO2h5TuqckwA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VgrSNPaEKBw0Zz8vvdp5zm6E446U3Kjcme/EK2Xv3lG+/0GF8kQSHtMOjEPMUpmvlrjDzg6ZIk/bmjtvic410Qmz5d901vGo4gF38xIDO5iYstMHGEKAesV5LliwhpwmCLNDF9pT+9D5YLsneBAu0wGn+piJeEZoeq1TE67BbjOA7HuDK6+Q/S3FPHOqoRvNwLZDUkEINR2qzmfTWIHg9cbmjGJ3hAfyayixGPBkyI7QeAYH6Ce+LhAFHf3OEMicHO1lBfNwIhjJ4Efdv0oYK9hXhHcwUyKSKmCjn3S1dBLy9M0NhcqLTH03s064jnqHtRZ1b4IfbjXaIrQtGsonxQ==
  • Cc: Jason Andryuk <jason.andryuk@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Fri, 15 Aug 2025 21:36:09 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

posix.c and minios.c implement the same named functions serving slightly
different purposes.

For xenbus_map()
posix.c maps the local /dev/xen/xsd_kva
minios.c maps dom0 via grant and there is open coding for stub_domid in
map_interface.

Change xenbus_map() to map the local domain's interface.  The default
grant table mapping is performed otherwise.

Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
---
v6:
R-b: Juergen

v5:
Re-order later
---
 tools/xenstored/domain.c | 5 -----
 tools/xenstored/minios.c | 4 +---
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c
index e282b5c5ed..cf5a54965a 100644
--- a/tools/xenstored/domain.c
+++ b/tools/xenstored/domain.c
@@ -512,11 +512,6 @@ static void *map_interface(domid_t domid)
        if (domid == store_domid)
                return xenbus_map();
 
-#ifdef __MINIOS__
-       if (domid == stub_domid)
-               return xenstore_buf;
-#endif
-
        return xengnttab_map_grant_ref(*xgt_handle, domid,
                                       GNTTAB_RESERVED_XENSTORE,
                                       PROT_READ|PROT_WRITE);
diff --git a/tools/xenstored/minios.c b/tools/xenstored/minios.c
index 60d921cf01..a214e23907 100644
--- a/tools/xenstored/minios.c
+++ b/tools/xenstored/minios.c
@@ -61,13 +61,11 @@ evtchn_port_t get_domain_evtchn(unsigned int domid)
 
 void *xenbus_map(void)
 {
-       return xengnttab_map_grant_ref(*xgt_handle, xenbus_master_domid(),
-                       GNTTAB_RESERVED_XENSTORE, PROT_READ|PROT_WRITE);
+       return xenstore_buf;
 }
 
 void unmap_xenbus(void *interface)
 {
-       xengnttab_unmap(*xgt_handle, interface, 1);
 }
 
 void early_init(bool live_update, bool dofork, const char *pidfile)
-- 
2.50.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.