Re: [PATCH v2] xen/arm: irq: add missing spin_unlock() in init_local_irq_data() error path

[Mykola Kvach <xakep.amatop@xxxxxxxxx>]

On Tue, Aug 12, 2025 at 2:07 PM Julien Grall <julien@xxxxxxx> wrote:
>
>
>
> On 11/08/2025 18:28, Julien Grall wrote:
> > Hi Mykola,
> >
> > On 11/08/2025 09:45, Mykola Kvach wrote:
> >> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
> >>
> >> If init_one_irq_desc() fails, init_local_irq_data() returns without
> >> releasing local_irqs_type_lock, leading to a possible deadlock.
> >>
> >> Release the lock before returning to ensure proper cleanup.
> >>
> >> Fixes: 2bb32b809250 ("xen/irq: Propagate the error from
> >> init_one_desc_irq() in init_*_irq_data()")
> >> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
> >> Reviewed-by: Denis Mukhin <dmukhin@xxxxxxxx>
> >
> > Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > I will commit the patch soon.
>
> This is now merged.

Thanks everyone for the reviews and merging!

Best regards,
Mykola

>
> Cheers,
>
> --
> Julien Grall
>