[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] Arm: drop assertion from page_is_ram_type()


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Tue, 19 Aug 2025 13:40:26 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I1BdeOuf9QUOOuYzEZ6NTRNDJNMVnMY5NhMV7Sz1540=; b=OwDhedBmyYgAFLoYSbE7XImM44ioCeRGurfiroOmMii0U2VSdRNDr86rhfHp0ZsvygSPjfsxwAPrhrKzNfBAfWaizKI5Erj309mX6Zl/YqlGlBPS4QxbBXaK7aYh6TZqEy9B4UdfMtmhUByyGqB0Kzc6fDONr9dTF6jPLpyCxhrSUdFUMQW2xqSovXfiGBFl5P0Jj4yHRoLdJWzseAmNdE77QyqFwDFfrixN9lQ0W6j9RFcJxncFD+2B9rXOPVFdpHjNwE6sIe8IaZFacyQySgs5ZchZxeExyUrcADMpoopgh0YxvARTEUM56CJ/s5iDiZwt2DKfT/MvpkRJqfgRVw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yvldbD4WCWC4Pbp3ws+7hwzCwLvYj6BokDqbdwyfNO8hzj4mbUR7QSV3M/+tGwj5wYtPPscEmcwZxGmIZ6X4GCLxx8AvcGTRzxLJ4Xu9c31NNwkLpmoSocEARgGTLdS0kCeC+0U2uDXEikL23gQIKSQCq9Jf7U2ev6S7iWXHLBF1uSoe988qYkWxncdu48FeYWkNq4v54L9BmNRk7geAsjj6Oh12BlG+OunPUXC4HrmUowZ3ScpkmdjoX43hdEkG8Wuf8Wm8eiwJOt5eYqdKpB2XLdA0i6RyNE+/GtHhqinhDEBHKidpJZ6HEv3sN/QWbN+GD8bHw2oJSssoG+ABZw==
  • Cc: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 19 Aug 2025 17:40:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-08-18 03:55, Jan Beulich wrote:
Its uses in offline_page() and query_page_offline() make it reachable on
Arm, as long as XEN_SYSCTL_page_offline_op doesn't have any Arm-specific
code added. It being reachable was even mentioned in the commit
introducing it, claiming it "clearly shouldn't be called on ARM just
yet".

However, dropping the assertion from a function of this name is deemed
problematic. Rename it to better reflect its sole purpose outside of
x86-specific code.

Fixes: 214c4cd94a80 ("xen: arm: stub page_is_ram_type")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.