Re: [PATCH v4 14/16] block-dma: migrate to dma_map_phys instead of map_page

[Keith Busch <kbusch@xxxxxxxxxx>]

On Tue, Aug 19, 2025 at 08:36:58PM +0300, Leon Romanovsky wrote:
>  static bool blk_dma_map_direct(struct request *req, struct device *dma_dev,
>               struct blk_dma_iter *iter, struct phys_vec *vec)
>  {
> -     iter->addr = dma_map_page(dma_dev, phys_to_page(vec->paddr),
> -                     offset_in_page(vec->paddr), vec->len, rq_dma_dir(req));
> +     iter->addr = dma_map_phys(dma_dev, vec->paddr, vec->len,
> +                     rq_dma_dir(req), 0);

Looks good.

Reviewed-by: Keith Busch <kbusch@xxxxxxxxxx>

Just a random thought when I had to double back to check what the "0"
means: many dma_ api's have a default macro without an "attrs" argument,
then an _attrs() version for when you need it. Not sure if you want to
strictly follow that pattern, but merely a suggestion.