[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] misra: add deviation for MISRA C Rule 11.3


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
  • Date: Wed, 20 Aug 2025 07:17:54 +0000
  • Accept-language: en-US, uk-UA, ru-RU
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8nk17zjqPVgk0nvhstfnHnzLMV54YaJzzHLf9YY3z7Y=; b=Mq4UoAoySplA0zMxcJSinR4YNtpb6FG/6S2pTxpgtOXUci44zX2E/f33OGGEKXMPQNaHKOrVIVtG7EkRtWwQo1C5q9mYHowUpsS0ZU3Cifds5tyMZbVxfZOlt9PTGmtXodEL4pRcWBXpa9enoHwyNQKVrKQUOXgbIecALURmuiTf5HWorFSVUyTvy/T6985BwnFaVPuaMdIVF47IkPiFZ4839Rvly6eRkzvTsbBvsNVTJ+Cu73NXQ/PUwUcAja7EMaCjsDmteafHs0OZVqVXpH79oIng3d/7A2HeHv8sKVtjTZzcgdF1K1+sbRcFE/gQvD+ABO9FiyayLucMhxVYmQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=muZ5Y+QChTbA+4QEil18v6QohFzVCd5TifPQXC8lgoK2jiWNzH+IYC/HqYw7IdY/CzejFUCuV5jdTNWzV3MMk5ct00JVPBS3dgNQrS4ui/gADtkw2uzG9LaN6TcnDEQk7VWvGO1XBXfLypZzPFNoqNqOjTyrs5Lwctap30vl4Gr5JJ1/dHUuOzOYG54inAryJYzRpBvANA1MjPsYfPV4+uwzzSdv68whZtUEfC0QRQybNCgKENV9fplPJyf8Msh6G/5BVsMwgrnxft5E7GQGtDne88GWSShl00BDGoW+YATIZHzrqBowlK5aO2yTscBEkCXBKANxHC4FR4oa67y36g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 20 Aug 2025 07:18:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHcEaKMMDydbZiTjE+UNGKddouDNQ==
  • Thread-topic: [PATCH] misra: add deviation for MISRA C Rule 11.3

MISRA C Rule 11.3 states: "A cast shall not be performed between a pointer
to object type and a pointer to a different object type."

Violations of this rule arise due to the 'container_of' macro, which casts
a member of a structure to its containing structure:
    container_of(ptr, type, member) ({                             \
           typeof_field(type, member) *__mptr = (ptr);             \
           (type *)( (char *)__mptr - offsetof(type,member) );})

The 'container_of' macro is safe because it relies on the standardized and
well-defined 'offsetof' macro to calculate the memory address of the
containing structure, while assuming proper alignment and ensuring no
undefined behavior, provided that the input pointer is valid and points to
the specified member.

Configure Eclair to suppress violation reports related to 'container_of
macro. Update 'deviations.rst' file accordingly. Add Rule 11.3 to the
monitored list.
No functional changes.

Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
---
Test CI pipeline:
https://gitlab.com/xen-project/people/dimaprkp4k/xen/-/pipelines/1992968166
---
 automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++
 automation/eclair_analysis/ECLAIR/monitored.ecl  | 1 +
 docs/misra/deviations.rst                        | 8 ++++++++
 3 files changed, 17 insertions(+)

diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl 
b/automation/eclair_analysis/ECLAIR/deviations.ecl
index 7f3fd35a33..3e595e3a8c 100644
--- a/automation/eclair_analysis/ECLAIR/deviations.ecl
+++ b/automation/eclair_analysis/ECLAIR/deviations.ecl
@@ -403,6 +403,14 @@ because the semantics of the 'noreturn' attribute do not 
alter the calling conve
 }
 -doc_end
 
+-doc_begin="Convesions in the 'container_of' macro are safe because it relies 
on
+the standardized and well-defined 'offsetof' macro to calculate the memory 
address
+of the containing structure, while assuming proper alignment and ensuring no
+undefined behavior, provided that the input pointer is valid and points to the
+specified member."
+-config=MC3A2.R11.3,reports+={safe,"any_area(any_loc(any_exp(macro(^container_of$))))"}
+-doc_end
+
 -doc_begin="Conversions from and to integral types are safe, in the assumption 
that the target type has enough bits to store the value.
 See also Section \"4.7 Arrays and Pointers\" of \"GCC_MANUAL\""
 -config=MC3A2.R11.6,casts+={safe,
diff --git a/automation/eclair_analysis/ECLAIR/monitored.ecl 
b/automation/eclair_analysis/ECLAIR/monitored.ecl
index 72698b2eb1..abfc102d60 100644
--- a/automation/eclair_analysis/ECLAIR/monitored.ecl
+++ b/automation/eclair_analysis/ECLAIR/monitored.ecl
@@ -45,6 +45,7 @@
 -enable=MC3A2.R10.2
 -enable=MC3A2.R11.1
 -enable=MC3A2.R11.2
+-enable=MC3A2.R11.3
 -enable=MC3A2.R11.6
 -enable=MC3A2.R11.7
 -enable=MC3A2.R11.8
diff --git a/docs/misra/deviations.rst b/docs/misra/deviations.rst
index 2119066531..33b045a5a9 100644
--- a/docs/misra/deviations.rst
+++ b/docs/misra/deviations.rst
@@ -393,6 +393,14 @@ Deviations related to MISRA C:2012 Rules:
        (i.e., less strict) alignment requirement are safe.
      - Tagged as `safe` for ECLAIR.
 
+   * - R11.3
+     - Convesions in the 'container_of' macro are safe because it relies on
+       the standardized and well-defined 'offsetof' macro to calculate the 
memory
+       address of the containing structure, while assuming proper alignment and
+       ensuring no undefined behavior, provided that the input pointer is valid
+       and points to the specified member.
+     - Tagged as `safe` for ECLAIR.
+
    * - R11.6
      - Conversions from and to integral types are safe, in the assumption that
        the target type has enough bits to store the value.
-- 
2.43.0



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.