[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] iommu/ipmmu-vmsa: Fix build with HAS_PCI=n
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
- Date: Thu, 21 Aug 2025 13:09:29 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AD2V5cMbk2gvlu7Wf4VjpePQ/aX+IIavPijQQGOzWvc=; b=bFxkFvY0ylhRZhvJ3Lo5ZRa+RBFBPqzIqpnPtq/x5jX2tRObxITifxd87IjieYgyBdsd3I+wakDx/csoioSE+P8Dve3fE41+nIMCbS+SUznsHmQmQFkO/7Sck7MGq04U0mztofGKG0tXOFdCpQoLMG6mwxCVfgGlFvjoPbXLmszO71j3i/Umor6W85atQN1TkSs/Sw7gdBrCggDBiT9LwGZ7mE7PoiLMZlbuOy9Wl1ChkTtUUc3JGg4PAShg4i8v4sHwaH8Qep5ZjvJsyQym/6OXbzezhX/Sz8RjaomeEIf8QdfbR3ndsMQqJQ7VKgtUBMKUlqtsQpslRE8AjxP7IQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IPEO0lPyZmF7Z0ES2fihZ/TqlozBZkZl5TjK/BlHcjU8fxAFQjEsA/G+WfMKtNvnzP92w1vTJ+nZypLd0nhjyqfZ1w5EIPCgkL9YMT7hEuf4DT/sjMUKpDi3jFiyxbNGBFtEYr4gIcnSf3gflFvwNIU/2WvyyxJABYXrUzM1kXnb0vPHOr0vu9qW7mqp9AaXXjFKm87OhvGzxoBMf82ZwA+lX0OIjlt3eQ3cXoqE7NR1FESnMWCq7qKwqY7qreKLcDp5mDu/1QJq9Bo/KXh8vmxpmXvsvYDT88jZ8v6mPEvAsLjXnV8jczYmEMfwtpskxvPvroZJv6QNqDHVvqsmYg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 21 Aug 2025 13:09:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcEol6WY2CZ9Gyh0KXEcdKpt6HNrRtAhqAgAASeQA=
- Thread-topic: [PATCH v1] iommu/ipmmu-vmsa: Fix build with HAS_PCI=n
On 21.08.25 15:03, Mykola Kvach wrote:
> Hi Mykyta,
>
> On Thu, Aug 21, 2025 at 1:51 PM Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
> wrote:
>>
>> With PCI disabled the build fails due to undefined struct
>> pci_host_bridge.
>>
>> Add ifdef guard around pci-host-rcar4.h to not include it when PCI
>> support is disabled.
>>
>> Signed-off-by: Mykyta Poturai <mykyta_poturai@xxxxxxxx>
>> ---
>> This patch can be squashed with iommu/ipmmu-vmsa: Implement basic PCIE-IPMMU
>> OSID support
>> ---
>> xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> index ea9fa9ddf3..49f149e222 100644
>> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> @@ -51,7 +51,9 @@
>> #include <asm/device.h>
>> #include <asm/io.h>
>> #include <asm/iommu_fwspec.h>
>> +#ifdef CONFIG_HAS_PCI
>> #include "../arch/arm/pci/pci-host-rcar4.h"
>> +#endif
>
> As far as I know, the IPMMU VMSA driver can also be used on other
> R-Car platforms. Is there a chance we could have HAS_PCI enabled
> together with IPMMU VMSA, but not be on an R-Car Gen4 platform,
> for example, on R-Car3 or possibly some future R-Car variants?
>
> Wouldn't it be better to use:
> #ifdef CONFIG_RCAR4
> ?
Gen5 boards will use SMMU, so this will not be applicable to them. In
any case, checking for RCAR4 will not help here, as PCI can be disabled
regardless of the platform revision.
>
> Best regards,
> Mykola
--
Mykyta
|
