[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v7 04/13] xen/cpufreq: add missing default: case for x86 vendor


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Penny Zheng <Penny.Zheng@xxxxxxx>
  • Date: Fri, 22 Aug 2025 18:52:09 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F93un5lAfvv0KNInBafr37fvQ4Y29SHKknyVE0PvlwA=; b=x71/hnKhv8jck8cSVMlI+a9wBmJyI+Igzas9oLTVBPXi4CrhmBeKWVZPhMgQgW3CLVDGJEWdeTIrjcvlOUHJol83UQPD0QgiKyl/yZ6Hm4lyN1jVOuAU06+Jnf0XSe8tXD4OTP8+65VjUv9uhn19Xr7sAK0T7gtgnaKkoqXI3SWT2kFqne1wJVI9O59f0rMxw8g5fLztOsvXPmgwkMYpAzaedA46Q5NSNCKAKTtSUAIsJ5cPmzhySU0bBRrseEZXlAPBuzAwl8mOKpWAZf8/oIXN9y3gF+3xDjruwhczTYSxm5/1pgXxFEjrfEMP4EN5xY9/XtB1Pfsd68slIYiILA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SqdlgndB8GcEaVBOQb4lqxvmhxRmI1InBSbX3y0A27DYwgnCPVwz6TIqEia94i49TTevHHA8n6vhyb1hiZa0JbI4wk30o00/mvDmPfXcXCD245z0M9+TA44vezEIdWCEvRPBChq4E7WBeVmfU/kRq/fpjIvkiwNNd6wVU7Hn65Ylw4SrGZ2NwozxyAvHUTYV1h2LgM/ia7PBhCAX7Qm0M/6MskNnzs5lF3GmALwWYWn3Y/Z7fFWzPiFP3UKNwM7WetThr88B/P6dQYhpDMP9A5wRd6A4cyQXjye3zKiT+Sde4QdIlAdQg8IDBXvoe9CxHlnzGSmRjgUOfgDBNHqg/A==
  • Cc: <ray.huang@xxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Fri, 22 Aug 2025 10:52:54 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Since we are missing default case for x86 vendor, there is possibility (i.e.
new vendor introduced) that we will return successfully while missing the
whole cpufreq driver initialization process.
Move "ret = -ENOENTRY" forward to cover default case for x86 vendor, and
add error log

Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
---
v6 -> v7:
- new commit
---
 xen/arch/x86/acpi/cpufreq/cpufreq.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c 
b/xen/arch/x86/acpi/cpufreq/cpufreq.c
index d18735c7ae..e227376bab 100644
--- a/xen/arch/x86/acpi/cpufreq/cpufreq.c
+++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c
@@ -131,11 +131,11 @@ static int __init cf_check cpufreq_driver_init(void)
 
     if ( cpufreq_controller == FREQCTL_xen )
     {
+        ret = -ENOENT;
+
         switch ( boot_cpu_data.x86_vendor )
         {
         case X86_VENDOR_INTEL:
-            ret = -ENOENT;
-
             for ( unsigned int i = 0; i < cpufreq_xen_cnt; i++ )
             {
                 switch ( cpufreq_xen_opts[i] )
@@ -162,6 +162,10 @@ static int __init cf_check cpufreq_driver_init(void)
         case X86_VENDOR_HYGON:
             ret = IS_ENABLED(CONFIG_AMD) ? powernow_register_driver() : 
-ENODEV;
             break;
+
+        default:
+            printk(XENLOG_ERR "Cpufreq: unsupported x86 vendor\n");
+            break;
         }
     }
 
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.