[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3] device-tree: fix infinite loop issue in 'assign_shared_memory()'
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- Date: Mon, 1 Sep 2025 09:26:45 +0000
- Accept-language: en-US, uk-UA, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CEWDpgFAqkk98uKrndfkSlsjqAdBOfj7hKp97yeBNbs=; b=aGjl26cAdORAyD6HlbcW4arPvoV5x9DJfQIDJ4oItr6zSyEawIbP6pvasgE6qQSq373QWg8W9DmlWCkrS2O4xw5gPnjPEQe9EwINTQ2254TBYE/WFr8JSWWFdzVASCnF4e18INH4U86kugrHC5l4fZ1PguDr8nKpCpQ+Akq5DoZw2yUXTSc2nvqUAB32x1A+xEjcfcFhiXsSOsrj18e4Uk3meSmY1v1J5VY48O8co0DkwKLK06Fbllq3LQTpQiMDI1P3nF98Wx7nuwX8s7xQ8NSQl+0qcMN/W9pB6AjXM7/Vx9biDictxFQ5jaMJue2UWq4dVXcjrrOMK7pr2M2sQg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o70lf2BFNXlVQ9ds0ZXZrW6nNqO+dq3muTlKV1yrJyM1f/9ZE9MPosg5uaAFgieC6TngT25N/fwHSn1TYKZT59LsHwlAOjxemIjExpaXy3w9/tQuraf2LalZf8f++uSbvatG3NUojNi7Bkzdf7aiMNhdwTcFTQdtVtA1+x7aB0hGB0L1U8huQi5l0Six9fi+DN02Qlc06F5oKy90slQK+vjEFs5r4Wfm6pp7j1YDsIj2nqipH9QkDm7kY95IT5wAF9tCSUM6rgXN3v/qMsM/Erup2caHsAqlC1AqWBpE7gFoprsM8pKYBtkllICwlsYEqYYdHG5g6LniSYGPmlf6Lw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Mon, 01 Sep 2025 09:26:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcGyKJ90rw+TS90UqWTJ4b0NemJA==
- Thread-topic: [PATCH v3] device-tree: fix infinite loop issue in 'assign_shared_memory()'
Fix an issue in the 'fail:' cleanup path of the 'assign_shared_memory()'
function where the use of an unsigned long 'i' with the condition
'--i >= 0' caused an infinite loop. Update the loop to use 'i--',
ensuring correct loop termination.
This change adheres to MISRA C Rule 14.3: "Controlling expressions shall
not be invariant."
Fixes: 041957bad382 ("xen/arm: Add additional reference to owner domain when
the owner is allocated")
Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
---
Changes in v3:
- inserted right Fixes tag, pointed by Andrew Cooper
Link to v2:
https://patchew.org/Xen/0e562f695e5db87ab80dde69cbcc0cfa14f94b21.1756373770.git.dmytro._5Fprokopchuk1@xxxxxxxx/
---
xen/common/device-tree/static-shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/common/device-tree/static-shmem.c
b/xen/common/device-tree/static-shmem.c
index 8023c0a484..79f23caa77 100644
--- a/xen/common/device-tree/static-shmem.c
+++ b/xen/common/device-tree/static-shmem.c
@@ -185,7 +185,7 @@ static int __init assign_shared_memory(struct domain *d,
paddr_t gbase,
return 0;
fail:
- while ( --i >= 0 )
+ while ( i-- )
put_page_nr(page + i, nr_borrowers);
return ret;
}
--
2.43.0
|
