[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] x86: Fix AMD_SVM and INTEL_VMX dependency
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Mon, 1 Sep 2025 12:43:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tx7ZavVeNdWWSvvu3rYjzhhUoflye+ydUcxwgk7J/DQ=; b=SaH+3qc4Lqo5Fm7o64e3DfTVABchOoLZ9HlYAxNX0cfS4oKg72ysFJvabyYT5Aze5IoqbSl+DSKr1lCR4GB0VWW50VtHg3KuNrWwEFdbLZN1YSIAQY0pE7a2p8YR0R3KvDcLjS7yEYjUKco8U6kj+YJsBLqkjHdlRiRbgt0IDCJb1Xz2HzOSx+ScxQaosc7jSC17Z9qHNDnjjRPSUVeErWyJY2xXSriZXzRr/vDhG1W1LULiz+TR6xzvmPcr5APO/1HEi2G+4Kz7TWpUPtSFUmBEvZp8WEEFty2Q140y8xC1HS/ccHYahQZJmdjOCNo5GEfz4XVmm+o12qcluUSQuQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oj7sykvF0xLMBJ26mQMmafupPJXedVk8RG08m8szZap3CGSh5IDK5iQjTQLQubz6/yU4rqW7y5y0tNr+zPyALliOhfcQrnTxxE26I0cUGqkUHYPHHo4Q5pPmOkwx3j+JgZBbYAoykmttPx97gfGBrGbQQ8mhoG9nIzTll9eEHuvTEGrGJVg4NH3rKxclK1PEhHtFruve0vx0L9mLp3Pv7LBT2RFx5zH2uzKv60Nt46WoDUaOfL7P2xscXVvfeWkbn0wMQoFhY8qCNS/z1K5nmf4QDrB+HRnEmvzf2PfyZ8lRoI6UXWVuCXPwXexaJN/sHLah3otn1XabLvKXg8Cqiw==
- Cc: Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 01 Sep 2025 10:44:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Commit e3ed540f2e9f was meant to make AMD_SVM dependent on AMD and
INTEL_VMX on INTEL. Such dependency should be done using 'depends on'
and not 'if' next to prompt that deals only with the visibility of the
given Kconfig option. This makes it impossible to e.g. disable INTEL_VMX
when INTEL is disabled (option is hidden).
Fixes: e3ed540f2e9f ("x86/hvm: add HVM-specific Kconfig")
Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
---
xen/arch/x86/hvm/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/hvm/Kconfig b/xen/arch/x86/hvm/Kconfig
index b903764bda0d..c85889ea8642 100644
--- a/xen/arch/x86/hvm/Kconfig
+++ b/xen/arch/x86/hvm/Kconfig
@@ -16,7 +16,8 @@ menuconfig HVM
if HVM
config AMD_SVM
- bool "AMD-V" if AMD && EXPERT
+ bool "AMD-V" if EXPERT
+ depends on AMD
default y
help
Enables virtual machine extensions on platforms that implement the
@@ -25,7 +26,8 @@ config AMD_SVM
If in doubt, say Y.
config INTEL_VMX
- bool "Intel VT-x" if INTEL && EXPERT
+ bool "Intel VT-x" if EXPERT
+ depends on INTEL
default y
select ARCH_VCPU_IOREQ_COMPLETION
help
--
2.43.0
|
