Re: [PATCH v5 14/15] xen/domain: allocate d->irq_caps before arch-specific initialization

[dmukhin@xxxxxxx]

On Fri, Aug 29, 2025 at 02:46:29PM -0700, Stefano Stabellini wrote:
> On Thu, 28 Aug 2025, dmukhin@xxxxxxx wrote:
> > From: Denis Mukhin <dmukhin@xxxxxxxx> 
> > 
[..]
> >  
> > +    /* Disallow sharing physical IRQ */
> > +    rc = irq_deny_access(d, info->irq);
> > +    if ( rc )
> > +    {
> > +        ns16x50_err(info, "virtual IRQ#%d: conflict w/ physical IRQ: %d\n",
> > +                    info->irq, rc);
> > +        return rc;
> > +    }
> 
> Also this one I wonder if it could be in hvm_domain_initialise, it would
> make more sense to keep the irq_deny_access there, compared to here
> which is supposed to be a generic emulator

I think it is better to have all vuart initialization in one place, at least
until MMIO-based variant is not available. Current code is x86-specific (port
handlers and IRQ emulation), there will be some changes to make code a generic
NS16550 emulator.