[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 06/22] xen/arch/x86: reserve TXT memory during Slaunch



On 22.09.2025 23:35, Sergii Dmytruk wrote:
> On Thu, Jul 10, 2025 at 03:00:07PM +0200, Jan Beulich wrote:
>> On 30.05.2025 15:17, Sergii Dmytruk wrote:
>>> +void __init txt_reserve_mem_regions(void)
>>> +{
>>> +    int rc;
>>> +    uint64_t sinit_base, sinit_size;
>>> +
>>> +    /* TXT Heap */
>>> +    BUG_ON(txt_heap_base == 0);
>>> +    printk("SLAUNCH: reserving TXT heap (%#lx - %#lx)\n", txt_heap_base,
>>> +           txt_heap_base + txt_heap_size);
>>
>> Please log ranges in a way that makes it unambiguous whether they're 
>> exclusive
>> or inclusive (especially at the upper end).
> 
> I'll use start:end notation which I think suggests inclusive bounds.

Please use mathematical notation when logging ranges, i.e. [a,b) or [a,b].

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.