[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/4] arm/gic: Use static irqaction
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
- Date: Mon, 29 Sep 2025 08:48:59 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6JebzVSnPshn5VcYXnyU+FoIqiAJQJxUQGCyo25WU9U=; b=LlCqopJssBTa5DTtQ/grSjBq6jdys3c4UtCtsCOW38KuUAb6ctSUtienKYo/P9iS1QKhddxpOtl8xQ9SiEaDkG3CDJj7KgSRulBWyhYQPMswDb95h0nTe/Trb+XRwXBYzbh3GoCB3/HDHRU9obGRSKM3HWQLjsrThfhGrdijk1NaItw1+Cm372A/mWuscZCCEzsPPiQdcNoyTWD1TuTMOjtmgM/FB/8MNX9afWN52K2ZetE4SjVokhIChs1+xzszSCaLkr/nmjGuOj5Rr+JVXAwrh1WZDMBw+OeJgErArRTGW1eC8OIhn1XpesDPQg1bZImBLefAKN6yoEGY/SEX9g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=h2r36sYkvQpsv/7vK2cd/6Rl7lY7fomd+EC3G1t2W1cnCWWCzp0HHG3em2i7BxRWi33F5aSQtUAy+T9VDOjUHPQiQ1k1Uj445zyGJaQqDQIh0lkG3ACy/4OHCtQzwflVnCySe2HQ00HIn2nMAC0Us/BEkWq5BolisUCiVmhtyqEbWrb52pmtnH6mva5mdpf+k69Xr9LzOhLIzFAo8gm/xqykfZ3P43LCdPIL8S7hyc9IodRvnfoQsV90V0Se/FuCBAam/f9wb7A9sbW6PdyuTXObags+yk7MaZhGHfXscGDnfFMT5NzXkFUNeiZwMbcoidlgpnhLZvNnTpInb2YelQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 29 Sep 2025 08:49:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcMR3luyMo51OjGE+9JG+sKBjsjw==
- Thread-topic: [PATCH v2 2/4] arm/gic: Use static irqaction
When stopping a core cpu_gic_callback is called in non-alloc
context, which causes xfree in release_irq to fail an assert.
To fix this, switch to a statically allocated irqaction that does not
need to be freed in release_irq.
Signed-off-by: Mykyta Poturai <mykyta_poturai@xxxxxxxx>
v1->v2:
* use percpu actions
---
xen/arch/arm/gic.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 260ee64cca..ed6853bb32 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -386,10 +386,17 @@ void gic_dump_info(struct vcpu *v)
gic_hw_ops->dump_state(v);
}
+DEFINE_PER_CPU_READ_MOSTLY(struct irqaction, irq_maintenance);
+
void init_maintenance_interrupt(void)
{
- request_irq(gic_hw_ops->info->maintenance_irq, 0, maintenance_interrupt,
- "irq-maintenance", NULL);
+ struct irqaction *maintenance = &this_cpu(irq_maintenance);
+
+ maintenance->name = "irq-maintenance";
+ maintenance->handler = maintenance_interrupt;
+ maintenance->dev_id = NULL;
+ maintenance->free_on_release = 0;
+ setup_irq(gic_hw_ops->info->maintenance_irq, 0, maintenance);
}
int gic_make_hwdom_dt_node(const struct domain *d,
--
2.34.1
|
