[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.21 1/2] x86/AMD: avoid REP MOVSB for Zen3/4


  • To: Teddy Astie <teddy.astie@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Mon, 29 Sep 2025 19:35:53 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vates.tech smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zkoHx2+S4uq+k0vWI6JD8rvHdJk0kuS9TDnXqa8RXu8=; b=KuXAutHiCzeOqa0KcDeyN7wVBGhc4E8E4ubJeVh6segvYD1K3cf490KvDeOkUZ493LHuOJwqVarH5yEfOUPounjoos9gPKus85h6jM0sMWO72bJA+I+s6E6wJ+fieGIaiB+onl2afwHcFFpFxFD16zxiWGUl7lrBRG7ijSmgy1eBv+5ON7zD+YzI9fmr8KxBwkqXqWBN4ugj0BAn1f2cp/biFitKAOP+l6UZWUUYmcuz0Vl7nPxupKr58H+w8/6+9zHYGnULTxbSmiS4AE+krqDJMbqkqeZvZe9FWhM/T6FZu5McK6L122bHA4gAnE09o7wPMdGDyX20K/4aGPodkw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=quGm0Up4sswlM/KECgcKMfgcxyHJyaShtbBEXM0PP3BFsWvPyDxIYuZCMtw8VDgJOeao6SHneaJmBi2o75lLhmPX/9FOA5tHR86FWeuwWf7ntIK93m3t2SaTbZcf5YLyWDxWa/+hAb2g7kqZ5ZR5DIGxehzxCa8nyAPuhmJFIRlUlAHwygu3ByuvEa3O60locukcghcxO54xbpzUMxHR0iPwnJoyurWCmqpV0ao9Qh9m63he15iw/rotM+xLrDMuqSlrV8aBqJSp+Lf6hpWKyMgnr3P+iaZqeI7NU/aajkMFuFF6S85b6RcHbXYswIs8jDgvWffw7SkdfgPw8PFMuA==
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
  • Delivery-date: Mon, 29 Sep 2025 23:36:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-09-25 08:18, Teddy Astie wrote:
Le 25/09/2025 à 12:48, Jan Beulich a écrit :
Along with Zen2 (which doesn't expose ERMS), both families reportedly
suffer from sub-optimal aliasing detection when deciding whether REP MOVSB
can actually be carried out the accelerated way. Therefore we want to
avoid its use in the common case (memset(), copy_page_hot()).

s/memset/memcpy (memset probably uses rep stosb which is not affected IIUC)


Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

With Teddy's suggested change:

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Thanks,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.