Re: [PATCH v2 14/17] system/physmem: Un-inline cpu_physical_memory_read/write()

[Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>]

On 30/9/25 07:02, Thomas Huth wrote:
> On 30/09/2025 06.13, Philippe Mathieu-Daudé wrote:
> > Un-inline cpu_physical_memory_read() and cpu_physical_memory_write().
> What's the reasoning for this patch?
Remove cpu_physical_memory_rw() in the next patch without having
to inline the address_space_read/address_space_write() calls in
"exec/cpu-common.h".

Maybe better squashing both together?

>   Thomas
>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
> > ---
> >   include/exec/cpu-common.h | 12 ++----------
> >   system/physmem.c          | 10 ++++++++++
> >   2 files changed, 12 insertions(+), 10 deletions(-)
> >
> > diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
> > index 6c7d84aacb4..6e8cb530f6e 100644
> > --- a/include/exec/cpu-common.h
> > +++ b/include/exec/cpu-common.h
> > @@ -133,16 +133,8 @@ void cpu_address_space_destroy(CPUState *cpu, int 
> > asidx);
> >   void cpu_physical_memory_rw(hwaddr addr, void *buf,
> >                               hwaddr len, bool is_write);
> > -static inline void cpu_physical_memory_read(hwaddr addr,
> > -                                            void *buf, hwaddr len)
> > -{
> > -    cpu_physical_memory_rw(addr, buf, len, false);
> > -}
> > -static inline void cpu_physical_memory_write(hwaddr addr,
> > -                                             const void *buf, hwaddr 
> > len)
> > -{
> > -    cpu_physical_memory_rw(addr, (void *)buf, len, true);
> > -}
> > +void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len);
> > +void cpu_physical_memory_write(hwaddr addr, const void *buf, hwaddr 
> > len);
> >   void *cpu_physical_memory_map(hwaddr addr,
> >                                 hwaddr *plen,
> >                                 bool is_write);
> > diff --git a/system/physmem.c b/system/physmem.c
> > index 70b02675b93..6d6bc449376 100644
> > --- a/system/physmem.c
> > +++ b/system/physmem.c
> > @@ -3188,6 +3188,16 @@ void cpu_physical_memory_rw(hwaddr addr, void 
> > *buf,
> >                        buf, len, is_write);
> >   }
> > +void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len)
> > +{
> > +    cpu_physical_memory_rw(addr, buf, len, false);
> > +}
> > +
> > +void cpu_physical_memory_write(hwaddr addr, const void *buf, hwaddr len)
> > +{
> > +    cpu_physical_memory_rw(addr, (void *)buf, len, true);
> > +}
> > +
> >   /* used for ROM loading : can write in RAM and ROM */
> >   MemTxResult address_space_write_rom(AddressSpace *as, hwaddr addr,
> >                                       MemTxAttrs attrs,