Re: [PATCH] x86/hap: Inline "flush_vcpu" in "flush_tlb"

["Teddy Astie" <teddy.astie@xxxxxxxxxx>]

Le 29/09/2025 à 21:41, Andrew Cooper a écrit :
> On 29/09/2025 1:36 pm, Teddy Astie wrote:
>> flush_vcpu static function here is only used in one place which is just below
>> where it is defined. Inline the function to reduce the noise and clarify
>> what we are doing.
>>
>> No functional change.
>>
>> Signed-off-by: Teddy Astie <teddy.astie@xxxxxxxxxx>
>
> Have you read the commit message introducing this pattern?  It's
> 11d9e114b53045e5f2009a26dad1d0d0f7df441e for reference.
>

Yes, and while it makes sense in shadow paging code where we use it
multiples times; it sounds to me a bit too much here to have such
function just used once.

> The compiler will do the sensible thing.  What matters is the cognitive
> complexity of the source code.
>
> ~Andrew
>

Teddy


--
Teddy Astie | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech