Re: [PATCH] MAINTAINERS: Add myself as an AMD SVM & IOMMU reviewer

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Oct 02, 2025 at 07:42:38PM -0400, Jason Andryuk wrote:
> Split out AMD SVM and AMD IOMMU, and add myself as a reviewer.  Jan,
> Andrew and Roger are set as maintainers as they were for the X86 entry.
> 
> Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Thanks for adding yourself!

I have on question below about the mechanics of MAINTAINERS parsing
(but no objection at all with you becoming a reviewer).

> ---
>  MAINTAINERS | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 793561f63f..0139edd88b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -220,6 +220,23 @@ F:       xen/drivers/acpi/
>  F:   xen/include/acpi/
>  F:   tools/libacpi/
>  
> +AMD SVM
> +M:   Jan Beulich <jbeulich@xxxxxxxx>
> +M:   Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> +M:   Roger Pau Monné <roger.pau@xxxxxxxxxx>
> +R:   Jason Andryuk <jason.andryuk@xxxxxxx>
> +S:   Supported
> +F:   xen/arch/x86/hvm/svm/
> +F:   xen/arch/x86/cpu/vpmu_amd.c
> +
> +AMD IOMMU
> +M:   Jan Beulich <jbeulich@xxxxxxxx>
> +M:   Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> +M:   Roger Pau Monné <roger.pau@xxxxxxxxxx>
> +R:   Jason Andryuk <jason.andryuk@xxxxxxx>
> +S:   Supported
> +F:   xen/drivers/passthrough/amd/
> +
>  ARGO
>  M:   Christopher Clark <christopher.w.clark@xxxxxxxxx>
>  R:   Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> @@ -601,7 +618,8 @@ M:        Roger Pau Monné <roger.pau@xxxxxxxxxx>
>  S:   Supported
>  L:   xen-devel@xxxxxxxxxxxxxxxxxxxx
>  F:   xen/arch/x86/
> -F:   xen/drivers/passthrough/amd/
> +X:   xen/arch/x86/hvm/svm/
> +X:   xen/arch/x86/cpu/vpmu_amd.c

Would it be possible to not exclude the SVM related code here, and
avoid having to duplicate the x86 maintainers on the AMD entries?

Or the parsing of the file doesn't deal with multiple entries possibly
covering the same files?

Thanks, Roger.