[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] libs/guest: don't use unsigned long as type for PFNs
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 6 Oct 2025 07:19:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=suse.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l0ND/d7eQYFHw6AQoAkVccHtBQUytZ1ujf/jgUpuCXM=; b=dmOKGxBevPgztBemJY/lR+abpgkG4lN2CJFWDcHI//KWItcXHZK5RYGu8/ZiYeg8x6Nobq/N04vfFc+J0ElTMOd6rulk62yKfIa5ushEWsIqTTSLJo3wdqa3sHW+nhW296+oV05vEtpqsRMRDF4umLL8GWQQmEUXwHPEejwESUMYCv+3ET5g+oja1ewXT4RuSaxiwTdMV/1JqEACC8/UdKtYyhJ0n9mD5mbH4Uwa31Js+0uCW7MSMabHaxVVKomFrOSeXOeQ2Ug7Q4y6c6A/21iUuP5sw9BRwyK0q/sod6w1HpPTH2wsY26RU2mYryDlP5g9qKZfFDZrqCwmQsTXxQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l0ND/d7eQYFHw6AQoAkVccHtBQUytZ1ujf/jgUpuCXM=; b=WUaMzeKgtR9BStT3lOsxKSTU+6ELmLJIHOJUGm70aqxEl/xlT55lIv0ypCHMfcKRgwwtlY5Fbv0AbXfipQMXWhqeXclWAInFNABRfMae4I5pT/qe5QAoYPugSy+RNbDqIZ9MXhIBUfZzQGxkiog+Sd0Xwcpu73q0+3J3WhGaVb/VZD97y1xEqCUgq8NIABmbLP8MTmP1embuSxMbNPCR9qIjI/ofwo/cSYDXKPQ2wXiJV7mqDIrLynsb3ahs5alk3Na15s4iH/ZGgyg99hchSsSO6ro9bAOETA8brKzRydizjeAUHCHMqVDZ0RMPP/niESuPd/dNJG1PIOCt0+1LDg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=RDpvyTSlufsaV86qV9JwykHoQcG0MSlWzvCBebpw1tyPeKcEPLMC1ZlBwdrEhRmoL3+0ejpv24OVGMhA5ZW0OnQglYJJAVBwVBkg8luBCbRvPONgzMKqiL+Hy2vbQk+BUkYDGecoSVgiobNut1BVBGX24r33S9qmAlV+8vFkCKIHKh1MyMopIygqdU2NwJbT3FAhri9gcjxF/VSOAERlxPwloLC6dfscbRyz8HI2SbM6s61t3uR+IrqktDhJzepmvRAivNTX2spST7QUUp/LrVz+eaF0Kx7Kjg+fitXi3z1KYnrp4nP2MIbaeUoRtRxSMfYg3MiCn362uh5vVhZjBQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TOTLx1vqQOBAHaMf6poLSQsZT0ACj/3azLlTbXdIzVYUK4w9oZZwQy8lgSabPVVZFq5WpB1ezwLtzAGWgqDL88o3P+5XobfYqJixGbBals8V3FCous6aL+ynACriciu1x8Vc9MR2i2dQX0xmB6zXvdK4614YR+7J4gbKQeZO6Pt3Ky/IO1lQH9xpr5IKGJ5udqDOsgoGfG/UHLoZ9WtuSQIWKLLpw1cHvMmYvdnV6Oih/P4qpIjkhdWUDbbjuUIBLoJDe5GQWEwDdQLyEgA60Tk2WLG/H66gOEKAUW4O33NMSK3Aze5Lu7L1mtIf2MSlbUV5+0LVLhocSd4tds+9+w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Mon, 06 Oct 2025 07:20:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcNoZt7mla/rsydU2n7oA1r/gbYLS0tfGA
- Thread-topic: [PATCH v2] libs/guest: don't use unsigned long as type for PFNs
Hi Juergen,
> On 6 Oct 2025, at 06:59, Juergen Gross <jgross@xxxxxxxx> wrote:
>
> Declarations of xc_dom_console_init() and
> xc_dom_console_set_disconnected() in libxenguest.h don't match their
> implementation in the library.
>
> Under arm32, xen_pfn_t is a uint64_t and wider than unsigned long.
>
> Use xen_pfn_t for GFNs in the library to fix that. At the same time
> change the parameter name of the implementation to console_gfn,
> matching the interface declaration in the header and reality (it is
> a GFN, not a PFN).
>
> Fixes: b6fc307b0b00 ("libs/guest: Set console as disconnected on resume")
> Fixes: 971b7d5ecbcd ("libs/guest: Set console page to disconnected")
> Reported-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> V2:
> - switch parameter name as well (Andrew Cooper)
> ---
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
