[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] libs/guest: don't use unsigned long as type for PFNs
- To: Juergen Gross <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Mon, 6 Oct 2025 09:17:36 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dJI+YTyaL4sD/ZNSkyggb7h+UOYpwjUzZLn5u4d72WQ=; b=SBeTIEe4emhtcW3b91vf00afMykKoACfiDtdWEpcufpaVi75uh6hUDl7ygviKVLg5Nczp+wc5+6YpXSdDpLci3dQbPdcsA1m/7kPBON4beWRmmH8hxbeqj7eGYKqxlB6iXpp1UnGCvDw2Mp1g2sBPEuiD8zaKeQu888hF7TYytsVxA0oUKgta2WBeqRE14rz9HLqsDwSAjG/BkkKhYc0TG2+RR/CKuOi9l5GtMqedC1C6pqLRb+4n2v5FGosqaC53yeY6a0Q2BhdZ/BLvQ7Xm8ksPVSO8JaTLDmE87HMcYxMgCszO2A7WjVCyB3zJygCYsiB+NFgauR6scuQLUjuVg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N47i8OyY1tomglRJgAPSFtfDXoHRmH0qyMpoa5e99EJ9+azQI8tHvjCbXKVNT9Vt44bS9QWmp2i2BNnVRJQOQ37uZi/b4/KpqSxV+CEsq/HXrX34j/1ZZ1QxMPgds8rnukNuvncqKDh2o1G2vCV86y3D2sX6RME22KlDpQMMIqcUVicBDlbqC0YsQ+JPMRCDQfS9T3VSH0ZbH6zqSIsdTza62zrvJfv15SC376IvrwV+9DzGCrfxXf4/trfsObM1lSGo94caluqSJ6Fv68mq9Z328j23ZsSSROi5ftVsJksjDMDhKd8LTMEU749q0mc6XuGTzDLPpnBwdi1wOQVSCw==
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>
- Delivery-date: Mon, 06 Oct 2025 13:17:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-10-06 01:59, Juergen Gross wrote:
Declarations of xc_dom_console_init() and
xc_dom_console_set_disconnected() in libxenguest.h don't match their
implementation in the library.
Under arm32, xen_pfn_t is a uint64_t and wider than unsigned long.
Use xen_pfn_t for GFNs in the library to fix that. At the same time
change the parameter name of the implementation to console_gfn,
matching the interface declaration in the header and reality (it is
a GFN, not a PFN).
Fixes: b6fc307b0b00 ("libs/guest: Set console as disconnected on resume")
Fixes: 971b7d5ecbcd ("libs/guest: Set console page to disconnected")
Reported-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
---
V2:
- switch parameter name as well (Andrew Cooper)
Thanks for doing this. I ran the original series through CI, but didn't
know that omits an arm32 toolstack build.
I see it's already in the tree, but here's an after-the-fact:
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Thanks again,
Jason
|
