Re: [PATCH v2] xen: Strip xen.efi by default

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Oct 07, 2025 at 04:12:13PM +0200, Jan Beulich wrote:
> On 02.10.2025 16:10, Marek Marczykowski-Górecki wrote:
> > On Thu, Oct 02, 2025 at 02:05:56PM +0100, Andrew Cooper wrote:
> >> On 12/06/2025 11:07 am, Frediano Ziglio wrote:
> >>> For xen.gz file we strip all symbols and have an additional
> >>> xen-syms file version with all symbols.
> >>> Make xen.efi more coherent stripping all symbols too.
> >>> xen.efi.elf can be used for debugging.
> >>>
> >>> Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxx>
> > 
> > Generally,
> > Reviewed-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> 
> Just to double check: You offer this after having read (and discarded) my
> comments on v1, which v2 left largely unaddressed? 

You mean the one about objcopy result used for debugging? I didn't see
that before, since I wasn't in cc on v1... 

Anyway, are you aware of some specific objcopy issue. Or in other words:
would xen.efi.elf _currently_ be broken (as in - unusable for
debugging/disassembly)? If not, then I take that relevant part of your
objection is mostly about inconsistent naming (xen.gz -> xen-syms, vs
xen.efi -> xen.efi.elf). Would xen-syms.efi.elf be better?

> IOW I continue to
> consider this a wrong move, and Andrew's remark towards "bootable vs not
> bootable" isn't quite relevant, seeing that prior to this patch we already
> had a way to strip the binary put onto the EFI partition (i.e. the one to
> be used for actual booting).

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature