[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 for-4.21 8/9] x86/HPET: don't use hardcoded 0 for "long timeout"
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 21 Oct 2025 15:21:25 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9OxUF/0kD7ZEzjMOi1Zx5DlVrHK0lK5HxUg+S0vDjAQ=; b=ghMnwZZQC0QgxOdlvWpApvguIjj9e7RFBAJd5J1j3chRC8Cn6T5bp6sneiowwA4GfT63M1pvH2/hhcSL+LeofIqQlgDddBv4F+Hp2kabcx8gZWS8TaiAhaNjEYjOX02HbHCMKd9CL5gT3/sZ6r6Iw5tqeTcuXAQCzLwRW2QsS+pDv1jjbbuCbrweMrukV7JSylgaIfkUBJ6TpZ+2fMZwMsUZsxkAOYBVo1nbhSOBsKcti16lqENQxyiczSHG4aX2IwIx4CBCHil2osngIKoXqXz24IGYvOViciXhTAf7GZUorgQes/Dqd0+ms46vWxhTOtdruMrFQPaDz3PenV9pWQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rU2phMCLVBYrJXoatzgYk8nCQ4eThBUs8YMMau7blz/LfZsRfmmdhXVLHHvcH7cMPkQmfDnw468z3VZmY17JHVLhhL0fWpB32pRE2vo4AJPoY1jF6GlFT4U00Bz9SIkXNuKkQyACwgR9TRaOgEZvK7zKfz8NHfGgajMIsrQ65DhlQEvQ7o/iF9581btBPzdrd/w+boKuJGAZ6YSwduIQr6isCq1gscQV/+7vRyoOew6hrcbMKSRcGY2tAN2cW21iGBYsTe77LuOqOGax/WxGLbfiDc8iO2VRbsuUmArzn5x9FFWUrGGBJQ1+LjeODl1BOUbANr9v4Dy0XINu1gQOTA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Tue, 21 Oct 2025 14:21:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Oct 20, 2025 at 01:21:18PM +0200, Jan Beulich wrote:
> With 32-bit counters, writing 0 means on average half the wrapping period
> until an interrupt would be raised. Yet of course in extreme cases an
> interrupt would be raised almost right away. Write the present counter
> value instead, to make the timeout predicatbly a full wrapping period.
>
> Fixes: e862b83e8433 ("CPUIDLE: Avoid remnant HPET intr while force
> hpetbroadcast")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Maybe I'm missing a path, but are there any callers that still pass
STIME_MAX to reprogram_hpet_evt_channel()?
hpet_broadcast_exit() no longer explicitly passes STIME_MAX like it
did in e862b83e8433, and then the per-cpu timer_deadline variable is
not set to STIME_MAX either in timer_softirq_action().
Thanks, Roger.
|
