[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] vtd: Remove IO_xAPIC_route_entry macro


  • To: Teddy Astie <teddy.astie@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 22 Oct 2025 11:15:38 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6A1MJbIBK9f1FqQJdobW71kVnUKHWBjhSG3tjRRy1BU=; b=dBlt2EbgX2FUF4uFI0qvrU6opwELAvGXHtityvUwTSl0UJDzJ1ervMXQIERJ1RyhpM2/2yWWlpMFsfEgIKlR2r3HEk9RE3OKtFJFs39JZZq+H8Y3hxvfbQ8W9AFVWrPzyB9RCgYvF1PlPGY2KJYFCmPg1r1Ta8GctPJrPBH8YJsSW/qCzHBIsHqIe+rqFRPKUgJAXBHIT4Kfz0iiucBWoYmYH5dMiBPr695NjJfx0fcLSZb+p2d2lw/9jUPwHK7d2aV/G/MjCqc5SNcLC5Abt3ScTqSKWQyVLMdWXA0jhUVwzlyFYB/bWCXXs7P0hHKfCK3mOou8ea/P73fQ7QzueA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IG59CU4qbRmqIE+2drzehNDX2a0L11fFDFeHfhu43uU5C7j1lcvdHtnl48pJkrP6wJKakwhfk3FQc6w9qxKmpfbr36vXXFt51wJ1dD95SJ+jsFu5Va1v6VBHt+jB0Cuc6ML6w1ock/N38Yc415oCxDt1t0t1DXIfQa2lkV5xHl+4t1FIrGTXLhBGTGLoJDVEc9oN5jdaONFTwA2/8jPwhRsvkI98ejq3zWvtqmYHdwjMhkg8zK/hFa+HafN644GsaXmHj68vDljsqNt4Mbw/4M9mPH3Y7aA2VZGzlvTqpjarp9qvXKJ/OMoa58a85n/RAR/nn0fphwfSiSBL4bTLbw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 22 Oct 2025 10:15:48 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22/10/2025 10:51 am, Teddy Astie wrote:
> This macro was introduced to abstract between IO-APIC and IO-SAPIC (ia64),
> now that ia64 isn't supported anymore, this macro now only refers to IO-APIC.
>
> Signed-off-by: Teddy Astie <teddy.astie@xxxxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> diff --git a/xen/drivers/passthrough/vtd/intremap.c 
> b/xen/drivers/passthrough/vtd/intremap.c
> index 7726ee618a..e0314aa469 100644
> --- a/xen/drivers/passthrough/vtd/intremap.c
> +++ b/xen/drivers/passthrough/vtd/intremap.c
> @@ -398,7 +398,7 @@ unsigned int cf_check io_apic_read_remap_rte(
>  {
>      unsigned int ioapic_pin = (reg - 0x10) / 2;
>      int index;
> -    struct IO_xAPIC_route_entry old_rte = { };
> +    struct IO_APIC_route_entry old_rte = { };

This should be tidied up to '= {};' as the line is being edited anyway.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.