[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] x86/ioapic: Don't open-code 32-bits rte reads
- To: Teddy Astie <teddy.astie@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 22 Oct 2025 11:22:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SuYiw2ae8Fg33zEpy9lQRUQxB0jHdD2BLe3ApLa6Alc=; b=qvVLfHpp4cjREEjW9jeDh5US4uNmvxNJTHTJY3ZzWHU6qNrZLrqG85xY4dEwMCIt0dzpWLQnT3ZRUI5l1ymhmi0MLBzxz9GryAZaxMtrAfa5R+32H9dqYojdEjiLtx7fcnZBlhJSJHJ6W00S4g4orQQE1Yw4L2eLxb090mErvSHc9UOjbWf8ucM5dmiUzXydDYyDJlI0hKhBpyyWd9R/Yf2IeJGU21qjOh969uReXXlJcMrlpqxFcZEAuXsWMpoxonswcrm47hbqCmYKNEd4uDH0ssodNLKYyNRRNdnXVPyPMx0QUUgCgn5CFGkr1N379eBIo2S9hebYz2eDppFCSQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bY4GqyXmCd1G+Py5M5vfPkvMrin1WlfKe0JZmlwEM93JlZQ98yZvS9LtAD6mWhK3jJOhctNK2xpt8OrvJ1HWrZ+XOrxqh2vMDGHjoaw7c1QblUaRYKiW4EQHjo6sXJIdGBep+cWyp5WaRJ5OZoK+g/rYkZd8+SdzJN5FPQwsD3UJx2NHKQ4QT5GecqsG6jTipYlA5I3URWDw0NbO1+gdro0XDKecPACUbCnBZ9hqKZJhO4HfJWp6Y7ihhO2J7chF1uWNBFZ5irUsvIDIiYN6NlK0PVyIyWo2p0UUUqRkNmu180Fs4qZA+Fj2w67I59i9S0xll0Y3BhmTY+LMYgSh3g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 22 Oct 2025 10:22:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22/10/2025 10:51 am, Teddy Astie wrote:
> diff --git a/xen/drivers/passthrough/vtd/intremap.c
> b/xen/drivers/passthrough/vtd/intremap.c
> index e0314aa469..3cdb892559 100644
> --- a/xen/drivers/passthrough/vtd/intremap.c
> +++ b/xen/drivers/passthrough/vtd/intremap.c
> @@ -399,7 +399,7 @@ unsigned int cf_check io_apic_read_remap_rte(
> unsigned int ioapic_pin = (reg - 0x10) / 2;
> int index;
> struct IO_APIC_route_entry old_rte = { };
> - int rte_upper = (reg & 1) ? 1 : 0;
> + unsigned int rte_upper = reg & 1;
bool?
But overall, a very nice cleanup.
~Andrew
|
