Re: [PATCH] xen: fix randconfig build problems after introducing SYSCTL

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 22 Oct 2025, Jan Beulich wrote:
> On 22.10.2025 06:39, Stefano Stabellini wrote:
> > --- a/xen/arch/x86/Kconfig
> > +++ b/xen/arch/x86/Kconfig
> > @@ -144,8 +144,7 @@ config XEN_IBT
> >  
> >  config SHADOW_PAGING
> >     bool "Shadow Paging"
> > -   default !PV_SHIM_EXCLUSIVE
> > -   depends on PV || HVM
> > +   depends on (PV || HVM) && !PV_SHIM_EXCLUSIVE
> >     help
> 
> On top of what Andrew said,

I wasn't aware of it. I'll drop this change and...


> I fear this is an issue I introduced. I just sent
> a fix for it. Clearly with the pre-existing issues related to domctl_lock_*()
> I failed to realize that some of the randconfig failures were due to a change
> of mine rather than Penny's.

... and use your patch instead.


> > --- a/xen/common/Kconfig
> > +++ b/xen/common/Kconfig
> > @@ -653,6 +653,7 @@ menu "Supported hypercall interfaces"
> >  
> >  config SYSCTL
> >     bool "Enable sysctl hypercall"
> > +   depends on !PV_SHIM_EXCLUSIVE
> >     default y
> >     help
> >       This option shall only be disabled on some dom0less systems, or
> 
> Didn't we say we'd drop the prompt? That would more cleanly be "going back to
> what it was before 34317c508294".

I prefer this change as it looks simpler and less intrusive. I am OK
with the alternative you suggested but I have tested this version.

For our own convenience I'll resend the two patches that I tested together.