Re: [XEN PATCH for-4.21] tools: require at least json-c 0.15

[Anthony PERARD <anthony@xxxxxxxxxxxxxx>]

On Thu, Oct 23, 2025 at 03:45:55PM +0100, Andrew Cooper wrote:
> On 23/10/2025 9:57 am, Anthony PERARD wrote:
> > From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> >
> > If not available, fallback to using YAJL.
> >
> > The code is using json_c_visit() which was introduced in 0.13.
> > json_object_new_null() and json_object_new_uint64() where added to
> > 0.14. And the last one json_object_new_array_ext() was introduced in
> > 0.15.
> >
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> However, you should adjust README and possibly Changelog.md to give this
> new minimum version.


Will this do?

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0cf9ad2d95..fc4f6d7c8a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,8 +14,8 @@ The format is based on [Keep a 
Changelog](https://keepachangelog.com/en/1.0.0/)
  - Debian Trixie added to CI.  Debian Bullseye retired from CI for RISC-V due
    to the baseline change.
  - Linux based device model stubdomains are now fully supported.
- - New dependency on library json-c, the toolstack will prefer it to `YAJL`
-   when available.
+ - New dependency on library json-c 0.15 or later, the toolstack will prefer it
+   to `YAJL` when available.

  - On x86:
    - Restrict the cache flushing done as a result of guest physical memory map
diff --git a/README b/README
index eaee78bd73..53a4d5c2ae 100644
--- a/README
+++ b/README
@@ -53,7 +53,8 @@ provided by your OS distributor:
     * Development install of Python 2.7 or later (e.g., python-dev)
     * Development install of curses (e.g., libncurses-dev)
     * Development install of uuid (e.g. uuid-dev)
-    * Development install of json-c (e.g. libjson-c-dev) or yajl (e.g. 
libyajl-dev)
+    * Development install of json-c 0.15 or later (e.g. libjson-c-dev)
+      or yajl (e.g. libyajl-dev)
     * Development install of libaio (e.g. libaio-dev) version 0.3.107 or
       greater.
     * Development install of GLib v2.0 (e.g. libglib2.0-dev)

Cheers,

-- 
Anthony PERARD