[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vVMX: Cleanup partial vCPU initialization
- To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 24 Oct 2025 19:08:01 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QXSdLoQI8GYo8dq1cVgYo9cAPdrEKz5fUSfvlSu5Ewg=; b=YZeZX9R8sSo2h1fLKy7df0vVcrE+1xv4pev/2xz1RzmZBg92cDZUP+dmNUN2UaBSdfSla5+Em96iEaDrnDBpg7MQ9tFNmkxFijNZnCGf4DLx7SPSPuzH16cGeJZtmi356JxJDu5VEhsgK4nnkqlna+EelqL9nAX5vVZhqWmPJRUv4AxeShrnnp9gYvg3IbFL19NX0ricJt/Q3skaPSPlNIIYoiUEWV0wX4F7xqld7b55p5wivrIM49Vt116NLhP9O/YftjnGmintpWDFZj0v4tbZmOk8tyy5TbRzLUyllOyTSyhG49gwPaqoXIzFSZYa/7LxC3yolOzuLChB1Y/TtQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TTcKydf99bXSEW6g+RGmuSma1gWKsyKU3WJ3iyJmNKL9fRcM++6CigR+2Cdb6KAi8sFsO2ozp+HBk0DhcJF+bn+R0+BgAPGczBOldLo0RCjhODdMwoQup3LCrUm2WztQs07rL+nnEVdbYIEOR+YQFkkAYf0FT9uxR0fG9sPs7fHImHDogK36ICnpk3huWLzlU9vgLFHdpHQbxJnoGQaHcgCkIZeQ0R4WhXOhUFJFg2fJH85a5bAxBOjywI5zgJiUWscXY+ykuruJL8t6zmdCiRnc7ATEN+qHB6fr6L2ROsDvGTo+/Yd2/lT86gE9aoNp8sd9eQt3HegLoEfQcQS1SQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 24 Oct 2025 18:08:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/10/2025 5:20 pm, Ross Lagerwall wrote:
> If nested vCPU initialization fails, cleanup the allocated memory since
> it is no longer handled by the caller.
>
> Fixes: c47984aabead ("nvmx: implement support for MSR bitmaps")
> Fixes: f5bdb4aaa165 ("x86/hvm: Obsolete the use of HVM_PARAM_NESTEDHVM")
> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
AFAICT, this is because of hvm_vcpu_initialise() not calling
nestedhvm_vcpu_destroy() if nestedhvm_vcpu_initialise() fails?
I think this is an improvement in the short term, but we really need to
fix our object lifecycle. Relatedly, I should dust off the fault-ttl
series because it would be able to find this failure automatically.
~Andrew
|
