[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/pci: prevent infinite loop for faulty SR-IOV cards
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 27 Oct 2025 09:43:04 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q/7Z10zYOAsa/TEjiw0CG+ZreGNRAvcNEKHiSQlFDO8=; b=qrr9zgTtYfpRWvD235+Mbev9cdgbcDz0//tBqOOKACRq643eyUx5GHfbZQea6s0U9TgUr8dP983CBXr64T3MwbSgN6zpYTwoRQGIQpi48XkJmr+HPmDxhvXW1SUyZB/JX0Ftl27pRRdnLpcYCz/nk2TdzM6WH2Ygi56D1T8y8OH1/aQpvrgbJwhqwBxQqKu0XKiVwoqxQR/m1qEhRVR2As2VXSqXg/kIJvRMDuqvmLPSmgbzFRa42L6xrSHQPC1h/XlsoDFVtWIChoz3mQFuK3Ie80bO6Fk41a83TGD6RjFSPWgKf8YED1KSdct6lTgifGs9c8tWYqUdKgeOEYilPw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eJ7QVMsGvS7ex7VgB0VgoDeSFc8SlqhAawz4w6Uj1PwS0nigov8ycZIX0ilFTNA6zXcw7pEwgz5WM0ddaKe+wfi5yUlFqEpJHFZso18VnyhP6TbdWqhDC6uwXrUBZBMRi0OYollI5KIGtL64Hpv73QSLbvHbYi3UFj0BbQU/V0UNPPHn5AYUSbtQpgdfenqcOp86tNhPFzMKcGCg8EtEvOQ4y0dqoXenuQE2Vj/Nqoj7/mION4SNg86gEzCy33+Mzk6YBBd2LWWQAvar3WTjTs6IVioGvdX06u/HXpKXTAN6qVqMFKZFxH/VrP0S+cOEfFJX9mX4NmSqwGuVwJ+FwA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Frediano Ziglio <freddy77@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Mon, 27 Oct 2025 08:43:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Oct 24, 2025 at 05:00:34PM +0100, Andrew Cooper wrote:
> On 24/10/2025 4:58 pm, Andrew Cooper wrote:
> > On 24/10/2025 4:13 pm, Frediano Ziglio wrote:
> >> If a SR-IOV card presents an I/O space inside a BAR the
> >> code will continue to loop on the same card.
> >> This is due to the missing increment of the cycle variable.
> >>
> >> Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxx>
> > Yes, that's buggy. Was this from a real card, or just code inspection?
>
> Sorry, sent too early.
>
> This was broken by a1a6d59862f4 ("pci: split code to size BARs from
> pci_add_device") when it changed the loop from having an increment, to not.
That was my fault.
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
I think we want to consider, this for 4.21, what's your opinion
Oleksii?
Thanks, Roger.
|
