[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.21] symbols: avoid emitting "end" symbols for data items
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 29 Oct 2025 20:13:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J7iCltpy8vsjKuNeZunqiKgTCTzeMoQ8MfB191qo8RA=; b=diI67vzOhlUvnmjei3KmpbdbMp0KLPStAwm5UeEnXxXfoL0U2tB5HYQtDQIauSBsInkYrUsq5mrX2qJSHZzXPriuEq/OU2eMTjo8t6gT7BVIM/Vk5u7oLdL4Vx4UtCnvtg7EtwkTFbOE4eERT282iaYVyLZqCcTPD1kL7xXCHdjTBKf7g/HuQ8bmLnCMoUAKI+2WV3kfDy1H1e/aJBs7yXhxbCnW6t0JjvEVjkrN8hY6qdeXUQyB10VCL6fnxGrMFPlSCInODYBifoGpMedeRtNUkjcVnQ8lZ/28ZbTdQLS/ZKQNEyo1tiKdn9DmycU4/iLDmrf3OaHI26EcwA8G2A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kFIP/QWnv5viD+mmMfYoPAco2elGfcolPUszRP1q6q3NdgI1vTvGdZV8uiXp4qCtpLiiXDKLiNiVyxU6pXU7psGUlwKPs6BiOMQbNMQKXjmwdwXTDQDUdYFqZSCHI03+QyZiB9RObZJLlwGwi857minvxZOPV9vPgiYqZxXDOW0yLj1kWExuNmuqQLngRe8F77nrCkBHu1kl7hPCpiQtXA2xTeFtqbDXqKPEPEu1J/7hw6Zr8RPP4DooQ4fJ9ZbBDtdwK/xyD0nqVz+jBBlB2xFmoxuG4Cv1gQZ6n9uS+2VqTPccWJRx/8kDuZarioMNEWTRq2EC2uCHltuYLVt+Wg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Wed, 29 Oct 2025 19:13:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Oct 29, 2025 at 02:34:29PM +0100, Jan Beulich wrote:
> symbols-dummy.c and the generated .xen-syms.?.S may place their symbols in
> different sections: Like for all C files, -fdata-sections may be in effect
> there. As a result, besides moving these symbols may then also have
> different amounts of "end" symbols inserted between them. While the
> movement is likely not problematic, the change in table size is - linking
> passes 2 and 3 want no address (and hence no size) changes between them.
>
> As, at least right now, the "end" symbols are useful only for code, limit
> their emission accordingly. When data symbols are emitted (i.e. when
> LIVEPATCH=y), this obviously also has a positive effect on overall table
> size (I'm seeing almost 600 entries going away in the build I'm looking
> at).
>
> Fixes: d3b637fba31b ("symbols: arrange to know where functions end")
> Reported-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks, this does seem to solve the issue I was seeing with clang +
LLD.
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Tested-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
With the commit message adjustment that you discussed with Andrew.
Roger.
|
