[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] acpi: Set TPM2 LAML to actual log area size
- To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 4 Nov 2025 17:07:55 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LfVdt6loshCTO2dVGLlMJQ477HgRFTE0fo6Gv6XKKFM=; b=mcpM6AxKO8GNhwJGSmmsOTjOmcfHEgWQvEOcuLp7iXOToXLmYPqX6CsMD+QVOPGafQZzAGIjTRShzTeDDRr++2rEWMO332LSdFJuUkc0iKOd1DtGOt9HUf4bvAN5T1a1GLv4rRB7+p/1YG2BkEWNdjuKgnrbFFrW5Ih1kPvXoxnVbvPNdTCzrYANYD462taBg7tR+2QYXAGmOrMbbotdOfUOOF3SB4ZTCiO0jJgXy9qdNLJhZkM1mM4B2ykSeWn9R1QajIzAnAekGTyT+kSgZUalr9VzrfQ5X67eb9Q7vIF2g6mlf5pwE9ePZoc92T1W8pER6azrTvwMPskr7HUdCg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S9y7Xq+k5/PA0OuWdqauTO76Bts3L+8aCwz+xCOaqFKJ75IsYRC/8seXqz+xvHBHNV/RIzq9NAuZzj41JWCthUj9lTlHT89OIDhvDM/cc6s5BPnrL+7WLxJC0WJ/CrI7NMEbWRrjl7juyK73Ak65ql/fCp3T12ivnYU1/tV1bSufk9W1HsT0DaEoBMccl4pD11oIHMKfl94v8oc9+D8HMNlECIDCiysHZ5KVOoPhcl3NKeoI8c4fSReuQ3So1p1Xc2P75CFD6T1Fr0hxIquE+1dNbRmiOP3bhuED7iVkcvuDgSHSt9Myr0oLTkOHol3CGNOTj84nqE/EGi4VlNsIHA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Daniel Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 04 Nov 2025 17:08:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04/11/2025 4:12 pm, Tu Dinh wrote:
> The LAML field should follow the TCG PFP specification:
>
> The TCG ACPI specification uses the field name "Log Area Minimum
> Length", but the field value is the actual log area length reserved by
> Platform Firmware, not a lower bound.
>
> Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
> ---
> tools/libacpi/build.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c
> index 2f29863db1..95188e217e 100644
> --- a/tools/libacpi/build.c
> +++ b/tools/libacpi/build.c
> @@ -473,7 +473,7 @@ static int construct_secondary_tables(struct acpi_ctxt
> *ctxt,
> tpm2->platform_class = TPM2_ACPI_CLASS_CLIENT;
> tpm2->control_area_address = TPM_CRB_CTRL_REQ;
> tpm2->start_method = TPM2_START_METHOD_CRB;
> - tpm2->log_area_minimum_length = TPM_LOG_AREA_MINIMUM_SIZE;
> + tpm2->log_area_minimum_length = TPM_LOG_SIZE;
These happen to be the same number, but in making this change
TPM_LOG_AREA_MINIMUM_SIZE becomes unused.
I suggest we delete the constant while at it. I don't think anything
good can come from having two of them.
Also, as it's no functional change, this is content for 4.22 I presume?
~Andrew
|
