[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH for-4.22 v2] acpi: Set TPM2 LAML to actual log area size



The LAML field should follow the TCG PFP specification:

The TCG ACPI specification uses the field name "Log Area Minimum
Length", but the field value is the actual log area length reserved by
Platform Firmware, not a lower bound.

Remove the now-unused TPM_LOG_AREA_MINIMUM_SIZE.

No functional change.

Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
---
v2: Remove the now-unused TPM_LOG_AREA_MINIMUM_SIZE.
---
 tools/libacpi/acpi2_0.h | 1 -
 tools/libacpi/build.c   | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h
index 6dfa939a8c..51623e2a8a 100644
--- a/tools/libacpi/acpi2_0.h
+++ b/tools/libacpi/acpi2_0.h
@@ -140,7 +140,6 @@ struct acpi_20_tpm2 {

 #define TPM_LOG_AREA_ADDRESS        0xFED50000

-#define TPM_LOG_AREA_MINIMUM_SIZE   (64 << 10)
 #define TPM_LOG_SIZE                (64 << 10)

 /*
diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c
index 2f29863db1..95188e217e 100644
--- a/tools/libacpi/build.c
+++ b/tools/libacpi/build.c
@@ -473,7 +473,7 @@ static int construct_secondary_tables(struct acpi_ctxt 
*ctxt,
             tpm2->platform_class = TPM2_ACPI_CLASS_CLIENT;
             tpm2->control_area_address = TPM_CRB_CTRL_REQ;
             tpm2->start_method = TPM2_START_METHOD_CRB;
-            tpm2->log_area_minimum_length = TPM_LOG_AREA_MINIMUM_SIZE;
+            tpm2->log_area_minimum_length = TPM_LOG_SIZE;
             tpm2->log_area_start_address = TPM_LOG_AREA_ADDRESS;

             set_checksum(tpm2,
--
2.43.0


--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.