[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[XEN][PATCH] xen/domctl: add XEN_DOMCTL_CDF_ALL mask


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
  • Date: Tue, 11 Nov 2025 20:16:27 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lm02RrJ+Zmog2LO5aBkDGYRaTMo3FfGlxm9+jCriFPg=; b=XUqlk62JGmvgKFWa4IEkg2UZwq8CkdQHrHUWMfWvMX6sqlEuRMttppLcgQe/THbs6bgxyPzGtJiZTwpUGIT/fXwbMKgPmQZF2NBu50MFF5Ku8oulcmgROxZ334L+JFHGqzAdJkXObwHNm9g7gedhlNMCbpgZneM4uaxeAOzQtvyjBns6h3pzvT0K7S1XrkLyptwdLoPLXxtma5/DRC/YokbicqeRBheJ6HFL/iAuWosXIcm49OCALvD6AsIEKkkLXUTTWbh/pZrJjH8Nuv4+oAKQ1qGv/iFu2k5V/ylyL+AnAZrAtr3CAMt3d4kvWs5Sz3KYmlkFC90H7d+hHsWpOw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zWEhgwYcZAKLbAiIgOtlrPftY9mCVsW8d/ToZzWuX5SUzjuX4/vitOYD2s2ey4XhyCzts63oKsxU7JyGIIc8l6zr78dovseY/Qi/RZfOgn46bB/at7vTDunSDOwLUUttayJD6jJFT7ndc8MbnRa+fN7cg/E89FZvdo4xCjlma2zreeXfmjnthQCa/QS1qejbGg/gY82ly/OqbdXy2w4fbSdEc/iNzzRkH1dJuhdnGlkU5cZs40IbliRDPH/Kol7QeTteA4uzcJ6ZUt5Yv3B2yLIkwW9KpJiAtvp8pMlRADjnNKoWjS5EjIS/prGSVGbSjsFuSkIwhXVvlUa0CXnOoA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Grygorii Strashko <grygorii_strashko@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Tue, 11 Nov 2025 20:16:37 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHcU0gPJuvEPEXhnkuhV+1ykI6wJw==
  • Thread-topic: [XEN][PATCH] xen/domctl: add XEN_DOMCTL_CDF_ALL mask

From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>

Every XEN_DOMCTL_CDF_x flag:
- is defined in public/domctl.h
- explicitly listed in sanitise_domain_config() (common/domain.c) to form
mask containing all supported DOMCTL_CDF flags for "Unknown CDF flags"
check.

So, it is required to modify two files every time XEN_DOMCTL_CDF_x flags
set is modified.

Simplify the things by introducing XEN_DOMCTL_CDF_ALL mask, so
sanitise_domain_config() no need to be modified any more.

Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
---
 xen/common/domain.c         | 7 +------
 xen/include/public/domctl.h | 7 +++++++
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/xen/common/domain.c b/xen/common/domain.c
index 775c33928585..4f91316ad93e 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -730,12 +730,7 @@ static int sanitise_domain_config(struct 
xen_domctl_createdomain *config)
     bool iommu = config->flags & XEN_DOMCTL_CDF_iommu;
     bool vpmu = config->flags & XEN_DOMCTL_CDF_vpmu;
 
-    if ( config->flags &
-         ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
-           XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
-           XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
-           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu |
-           XEN_DOMCTL_CDF_trap_unmapped_accesses) )
+    if ( config->flags & ~XEN_DOMCTL_CDF_ALL )
     {
         dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
         return -EINVAL;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 8f6708c0a7cd..94a8e3042cbf 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -72,6 +72,13 @@ struct xen_domctl_createdomain {
 /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */
 #define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_trap_unmapped_accesses
 
+#define XEN_DOMCTL_CDF_ALL                                                     
\
+        (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |                             
\
+         XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |                
\
+         XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |                     
\
+         XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu |                    
\
+         XEN_DOMCTL_CDF_trap_unmapped_accesses)
+
     uint32_t flags;
 
 #define _XEN_DOMCTL_IOMMU_no_sharept  0
-- 
2.34.1



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.